Title: [141662] trunk/Source/_javascript_Core
- Revision
- 141662
- Author
- fpi...@apple.com
- Date
- 2013-02-01 16:26:25 -0800 (Fri, 01 Feb 2013)
Log Message
Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
https://bugs.webkit.org/show_bug.cgi?id=108717
Reviewed by Mark Hahnenberg.
I think this makes the code clearer. It doesn't change behavior.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (141661 => 141662)
--- trunk/Source/_javascript_Core/ChangeLog 2013-02-02 00:25:01 UTC (rev 141661)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-02-02 00:26:25 UTC (rev 141662)
@@ -1,3 +1,15 @@
+2013-02-01 Filip Pizlo <fpi...@apple.com>
+
+ Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
+ https://bugs.webkit.org/show_bug.cgi?id=108717
+
+ Reviewed by Mark Hahnenberg.
+
+ I think this makes the code clearer. It doesn't change behavior.
+
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::parse):
+
2013-02-01 Mark Hahnenberg <mhahnenb...@apple.com>
Structure should have a StructureRareData field to save space
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (141661 => 141662)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-02-02 00:25:01 UTC (rev 141661)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2013-02-02 00:26:25 UTC (rev 141662)
@@ -3730,6 +3730,13 @@
dataLogF("Processing local variable phis.\n");
#endif
+ for (BlockIndex blockIndex = 0; blockIndex < m_graph.m_blocks.size(); ++blockIndex) {
+ BasicBlock* block = m_graph.m_blocks[blockIndex].get();
+ ASSERT(block);
+ if (!block->isReachable)
+ m_graph.m_blocks[blockIndex].clear();
+ }
+
m_currentProfilingIndex = m_currentIndex;
processPhiStack<LocalPhiStack>();
@@ -3738,13 +3745,6 @@
#endif
processPhiStack<ArgumentPhiStack>();
- for (BlockIndex blockIndex = 0; blockIndex < m_graph.m_blocks.size(); ++blockIndex) {
- BasicBlock* block = m_graph.m_blocks[blockIndex].get();
- ASSERT(block);
- if (!block->isReachable)
- m_graph.m_blocks[blockIndex].clear();
- }
-
fixVariableAccessPredictions();
for (BlockIndex blockIndex = 0; blockIndex < m_graph.m_blocks.size(); ++blockIndex) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
