Title: [141503] trunk
- Revision
- 141503
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-31 16:37:22 -0800 (Thu, 31 Jan 2013)
Log Message
[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=108200
Patch by Joanmarie Diggs <jdi...@igalia.com> on 2013-01-31
Reviewed by Martin Robinson.
Source/WebCore:
Getting the Position of a PseudoElement now triggers an assertion.
This can occur when clicking on empty space in a render block.
Looking to the unignored parent's node (and passing that accessible
object on in a signal to Assistive Technologies) seems like the most
reasonable thing to do here.
No new tests; instead skipping two tests that were crashing as a result.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(objectFocusedAndCaretOffsetUnignored):
LayoutTests:
Unskip two crashing tests having fixed the underlying bug.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (141502 => 141503)
--- trunk/LayoutTests/ChangeLog 2013-02-01 00:25:43 UTC (rev 141502)
+++ trunk/LayoutTests/ChangeLog 2013-02-01 00:37:22 UTC (rev 141503)
@@ -1,3 +1,14 @@
+2013-01-31 Joanmarie Diggs <jdi...@igalia.com>
+
+ [GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
+ https://bugs.webkit.org/show_bug.cgi?id=108200
+
+ Reviewed by Martin Robinson.
+
+ Unskip two crashing tests having fixed the underlying bug.
+
+ * platform/gtk/TestExpectations:
+
2013-01-31 Ojan Vafai <o...@chromium.org>
Rebaseline after r141459.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (141502 => 141503)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-02-01 00:25:43 UTC (rev 141502)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-02-01 00:37:22 UTC (rev 141503)
@@ -519,9 +519,6 @@
webkit.org/b/107377 storage/indexeddb/objectstore-basics.html [ Crash Pass ]
webkit.org/b/107194 storage/indexeddb/objectstore-basics-workers.html [ Crash Failure ]
-webkit.org/b/108200 fast/css-generated-content/block-and-box-hit-testing.html [ Crash Pass ]
-webkit.org/b/108200 fast/css/relative-positioned-block-crash.html [ Crash Pass ]
-
webkit.org/b/108365 http/tests/security/inactive-document-with-empty-security-origin.html [ Crash ]
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (141502 => 141503)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 00:25:43 UTC (rev 141502)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 00:37:22 UTC (rev 141503)
@@ -1,3 +1,21 @@
+2013-01-31 Joanmarie Diggs <jdi...@igalia.com>
+
+ [GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
+ https://bugs.webkit.org/show_bug.cgi?id=108200
+
+ Reviewed by Martin Robinson.
+
+ Getting the Position of a PseudoElement now triggers an assertion.
+ This can occur when clicking on empty space in a render block.
+ Looking to the unignored parent's node (and passing that accessible
+ object on in a signal to Assistive Technologies) seems like the most
+ reasonable thing to do here.
+
+ No new tests; instead skipping two tests that were crashing as a result.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (objectFocusedAndCaretOffsetUnignored):
+
2013-01-31 Kentaro Hara <hara...@chromium.org>
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (141502 => 141503)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-02-01 00:25:43 UTC (rev 141502)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-02-01 00:37:22 UTC (rev 141503)
@@ -1093,7 +1093,9 @@
if (axFirstChild)
startNode = axFirstChild->node();
}
- if (!startNode)
+ // Getting the Position of a PseudoElement now triggers an assertion.
+ // This can occur when clicking on empty space in a render block.
+ if (!startNode || startNode->isPseudoElement())
startNode = firstUnignoredParent->node();
// Check if the node for the first parent object not ignoring
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
