Title: [141409] trunk/Source/WebCore
Revision
141409
Author
[email protected]
Date
2013-01-31 05:42:42 -0800 (Thu, 31 Jan 2013)

Log Message

Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
https://bugs.webkit.org/show_bug.cgi?id=108468

Reviewed by Pavel Feldman.

We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar.
Right now we only show launcher view upon deleting the last profile header (of any profile type).

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141408 => 141409)


--- trunk/Source/WebCore/ChangeLog	2013-01-31 13:39:59 UTC (rev 141408)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 13:42:42 UTC (rev 141409)
@@ -1,3 +1,16 @@
+2013-01-31  Andrey Adaikin  <[email protected]>
+
+        Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
+        https://bugs.webkit.org/show_bug.cgi?id=108468
+
+        Reviewed by Pavel Feldman.
+
+        We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar.
+        Right now we only show launcher view upon deleting the last profile header (of any profile type).
+
+        * inspector/front-end/ProfilesPanel.js:
+        (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
+
 2013-01-31  Eugene Klyuchnikov  <[email protected]>
 
         Web Inspector: [Network] Columns are misaligned as first row goes out of sight.

Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (141408 => 141409)


--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js	2013-01-31 13:39:59 UTC (rev 141408)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js	2013-01-31 13:42:42 UTC (rev 141409)
@@ -609,8 +609,11 @@
 
         // No other item will be selected if there aren't any other profiles, so
         // make sure that view gets cleared when the last profile is removed.
-        if (!this._profiles.length)
-            this.closeVisibleView();
+        if (!sidebarParent.children.length) {
+            this.profilesItemTreeElement.select();
+            this._showLauncherView();
+            sidebarParent.hidden = true;
+        }
     },
 
     /**
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to