Title: [141356] trunk/Source
Revision
141356
Author
[email protected]
Date
2013-01-30 18:13:12 -0800 (Wed, 30 Jan 2013)

Log Message

Start sending scrollType as NonBubblingGesture for flings
https://bugs.webkit.org/show_bug.cgi?id=108372

Patch by Yusuf Ozuysal <[email protected]> on 2013-01-30
Reviewed by James Robinson.

Source/Platform:

Using the newly defined scrollType layerTreeHostImpl will stop bubbling flings to
parent layers. It will only bubble if the child layer is at the end of its scroll
range

* chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

Modified Paths

Diff

Modified: trunk/Source/Platform/ChangeLog (141355 => 141356)


--- trunk/Source/Platform/ChangeLog	2013-01-31 02:11:47 UTC (rev 141355)
+++ trunk/Source/Platform/ChangeLog	2013-01-31 02:13:12 UTC (rev 141356)
@@ -1,3 +1,16 @@
+2013-01-30  Yusuf Ozuysal  <[email protected]>
+
+        Start sending scrollType as NonBubblingGesture for flings
+        https://bugs.webkit.org/show_bug.cgi?id=108372
+
+        Reviewed by James Robinson.
+
+        Using the newly defined scrollType layerTreeHostImpl will stop bubbling flings to
+        parent layers. It will only bubble if the child layer is at the end of its scroll
+        range
+
+        * chromium/public/WebInputHandlerClient.h:
+
 2013-01-30  Dana Jansens  <[email protected]>
 
         [chromium] Add recordRenderingStats to WebSettings

Modified: trunk/Source/Platform/chromium/public/WebInputHandlerClient.h (141355 => 141356)


--- trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2013-01-31 02:11:47 UTC (rev 141355)
+++ trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2013-01-31 02:13:12 UTC (rev 141356)
@@ -39,7 +39,8 @@
     };
     enum ScrollInputType {
         ScrollInputTypeGesture,
-        ScrollInputTypeWheel
+        ScrollInputTypeWheel,
+        ScrollInputTypeNonBubblingGesture
     };
 
     // Selects a layer to be scrolled at a given point in window coordinates.

Modified: trunk/Source/WebKit/chromium/ChangeLog (141355 => 141356)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:11:47 UTC (rev 141355)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:13:12 UTC (rev 141356)
@@ -1,3 +1,13 @@
+2013-01-30  Yusuf Ozuysal  <[email protected]>
+
+        Start sending scrollType as NonBubblingGesture for flings
+        https://bugs.webkit.org/show_bug.cgi?id=108372
+
+        Reviewed by James Robinson.
+
+        * src/WebCompositorInputHandlerImpl.cpp:
+        (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
+
 2013-01-30  Tien-Ren Chen  <[email protected]>
 
         [chromium] Add WebFrame::visibleContentRect()

Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (141355 => 141356)


--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2013-01-31 02:11:47 UTC (rev 141355)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2013-01-31 02:13:12 UTC (rev 141356)
@@ -216,7 +216,7 @@
 
 WebCompositorInputHandlerImpl::EventDisposition WebCompositorInputHandlerImpl::handleGestureFling(const WebGestureEvent& gestureEvent)
 {
-    WebInputHandlerClient::ScrollStatus scrollStatus = m_inputHandlerClient->scrollBegin(WebPoint(gestureEvent.x, gestureEvent.y), WebInputHandlerClient::ScrollInputTypeGesture);
+    WebInputHandlerClient::ScrollStatus scrollStatus = m_inputHandlerClient->scrollBegin(WebPoint(gestureEvent.x, gestureEvent.y), WebInputHandlerClient::ScrollInputTypeNonBubblingGesture);
     switch (scrollStatus) {
     case WebInputHandlerClient::ScrollStatusStarted: {
         if (gestureEvent.sourceDevice == WebGestureEvent::Touchpad)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to