Title: [141341] trunk/Tools
Revision
141341
Author
roger_f...@apple.com
Date
2013-01-30 16:49:05 -0800 (Wed, 30 Jan 2013)

Log Message

Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.

Rubberstamped by Timothy Horton.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (141340 => 141341)


--- trunk/Tools/ChangeLog	2013-01-31 00:32:17 UTC (rev 141340)
+++ trunk/Tools/ChangeLog	2013-01-31 00:49:05 UTC (rev 141341)
@@ -1,3 +1,12 @@
+2013-01-30  Roger Fong  <roger_f...@apple.com>
+
+        Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
+
+        Rubberstamped by Timothy Horton.
+
+        * Scripts/webkitpy/tool/steps/runtests.py:
+        (RunTests.run):
+
 2013-01-30  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed, rolling out r141205.

Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (141340 => 141341)


--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-01-31 00:32:17 UTC (rev 141340)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-01-31 00:49:05 UTC (rev 141341)
@@ -27,7 +27,9 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
-
+import os
+import platform
+import sys
 from webkitpy.tool.steps.abstractstep import AbstractStep
 from webkitpy.tool.steps.options import Options
 from webkitpy.common.system.executive import ScriptError
@@ -77,17 +79,21 @@
             except ScriptError, e:
                 _log.info("Error running webkit_unit_tests: %s" % e.message_with_output())
 
+
         _log.info("Running run-webkit-tests")
         args = self._tool.deprecated_port().run_webkit_tests_command()
         if self._options.non_interactive:
             args.extend([
                 "--no-new-test-results",
                 "--no-show-results",
-                "--skip-failing-tests",
                 "--exit-after-n-failures=%s" % self.NON_INTERACTIVE_FAILURE_LIMIT_COUNT,
                 "--quiet",
             ])
 
+        if sys.platform != "cygwin":
+            args.append("--skip-failing-test")
         if self._options.quiet:
             args.append("--quiet")
+
         self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
+        
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to