Title: [141331] trunk
Revision
141331
Author
t...@chromium.org
Date
2013-01-30 15:27:05 -0800 (Wed, 30 Jan 2013)

Log Message

[Chromium] Enable textarea resize corner for tests
https://bugs.webkit.org/show_bug.cgi?id=108385

Reviewed by Ojan Vafai.

Tools:

We should test what we ship. Also, this makes us pass more tests in content_shell.

* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset): Turn on resize corner.

LayoutTests:

* compositing/overflow/textarea-scroll-touch-expected.txt:
* fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html:
This ref test would overlay 2 textarea on top of each other. Turn off the resize corner on one of them.
* fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Turn off the resize corner since the reference
file doesn't use a textarea.
* fast/repaint/textarea-set-disabled-expected.png:
* platform/chromium-linux/editing/inserting/4960120-1-expected.png:
* platform/chromium-linux/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png:
* platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
* platform/chromium-linux/fast/forms/basic-textareas-expected.png:
* platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
* platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/chromium-linux/fast/forms/negativeLineHeight-expected.png:
* platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
* platform/chromium-linux/fast/forms/textarea-align-expected.png:
* platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png:
* platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png:
* platform/chromium-linux/fast/forms/textarea-setinnerhtml-expected.png:
* platform/chromium-linux/fast/forms/textarea-width-expected.png:
* platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
* platform/chromium-linux/fast/parser/entity-comment-in-textarea-expected.png:
* platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
* platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
* platform/chromium-linux/fast/table/003-expected.png:
* platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png:
* platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png:
* platform/chromium/TestExpectations: Mark image failures for Mac and Win.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (141330 => 141331)


--- trunk/LayoutTests/ChangeLog	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/LayoutTests/ChangeLog	2013-01-30 23:27:05 UTC (rev 141331)
@@ -1,3 +1,47 @@
+2013-01-30  Tony Chang  <t...@chromium.org>
+
+        [Chromium] Enable textarea resize corner for tests
+        https://bugs.webkit.org/show_bug.cgi?id=108385
+
+        Reviewed by Ojan Vafai.
+
+        * compositing/overflow/textarea-scroll-touch-expected.txt:
+        * fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html:
+        This ref test would overlay 2 textarea on top of each other. Turn off the resize corner on one of them.
+        * fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Turn off the resize corner since the reference
+        file doesn't use a textarea.
+        * fast/repaint/textarea-set-disabled-expected.png:
+        * platform/chromium-linux/editing/inserting/4960120-1-expected.png:
+        * platform/chromium-linux/editing/pasteboard/pasting-tabs-expected.png:
+        * platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png:
+        * platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
+        * platform/chromium-linux/fast/forms/basic-textareas-expected.png:
+        * platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
+        * platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
+        * platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
+        * platform/chromium-linux/fast/forms/negativeLineHeight-expected.png:
+        * platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-align-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-setinnerhtml-expected.png:
+        * platform/chromium-linux/fast/forms/textarea-width-expected.png:
+        * platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
+        * platform/chromium-linux/fast/parser/entity-comment-in-textarea-expected.png:
+        * platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
+        * platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
+        * platform/chromium-linux/fast/table/003-expected.png:
+        * platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png:
+        * platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
+        * platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png:
+        * platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
+        * platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png:
+        * platform/chromium/TestExpectations: Mark image failures for Mac and Win.
+
 2013-01-30  Simon Fraser  <simon.fra...@apple.com>
 
         Elements that dynamically become fixed sometimes jump to the top left on scrolling

Modified: trunk/LayoutTests/compositing/overflow/textarea-scroll-touch-expected.txt (141330 => 141331)


--- trunk/LayoutTests/compositing/overflow/textarea-scroll-touch-expected.txt	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/LayoutTests/compositing/overflow/textarea-scroll-touch-expected.txt	2013-01-30 23:27:05 UTC (rev 141331)
@@ -9,7 +9,7 @@
           (position 18.00 18.00)
           (bounds 206.00 126.00)
           (drawsContent 1)
-          (children 2
+          (children 3
             (GraphicsLayer
               (position 1.00 1.00)
               (bounds 204.00 124.00)
@@ -23,16 +23,21 @@
             )
             (GraphicsLayer
               (position 190.00 1.00)
-              (bounds 15.00 124.00)
+              (bounds 15.00 109.00)
               (drawsContent 1)
             )
+            (GraphicsLayer
+              (position 190.00 110.00)
+              (bounds 15.00 15.00)
+              (drawsContent 1)
+            )
           )
         )
         (GraphicsLayer
           (position 248.00 18.00)
           (bounds 206.00 126.00)
           (drawsContent 1)
-          (children 2
+          (children 3
             (GraphicsLayer
               (position 1.00 1.00)
               (bounds 204.00 124.00)
@@ -46,9 +51,14 @@
             )
             (GraphicsLayer
               (position 190.00 1.00)
-              (bounds 15.00 124.00)
+              (bounds 15.00 109.00)
               (drawsContent 1)
             )
+            (GraphicsLayer
+              (position 190.00 110.00)
+              (bounds 15.00 15.00)
+              (drawsContent 1)
+            )
           )
         )
       )

Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html (141330 => 141331)


--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html	2013-01-30 23:27:05 UTC (rev 141331)
@@ -6,7 +6,7 @@
 <body>
 
 <div>
-    <textarea placeholder="This is a placeholder text." rows="4" cols="30" style="position: absolute; background-color: transparent;"></textarea>
+    <textarea placeholder="This is a placeholder text." rows="4" cols="30" style="position: absolute; background-color: transparent; resize: none"></textarea>
     <textarea rows="4" cols="30">before
 
 after</textarea>

Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow.html (141330 => 141331)


--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow.html	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow.html	2013-01-30 23:27:05 UTC (rev 141331)
@@ -3,7 +3,7 @@
 
 <p>When the AuthorShadowDOM does not have a shadow element, this should be rendered like div.</p>
 <form>
-    <textarea id="host" style="width: 100px; height: 50px; margin: 0; padding: 0; border: 0">Mami</textarea>
+    <textarea id="host" style="width: 100px; height: 50px; margin: 0; padding: 0; border: 0; resize: none">Mami</textarea>
     <input id="submit" type="submit" value="Submit">
 </form>
 

Modified: trunk/LayoutTests/fast/repaint/textarea-set-disabled-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141330 => 141331)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-30 23:27:05 UTC (rev 141331)
@@ -4343,6 +4343,38 @@
 crbug.com/170722 [ Mac Win Linux ] compositing/visibility/visibility-image-layers.html [ ImageOnlyFailure ]
 crbug.com/170722 fast/sub-pixel/transformed-iframe-copy-on-scroll.html [ ImageOnlyFailure ]
 
+# Rebaseline after turning on textarea resize corners.
+webkit.org/b/108383 [ Mac Win ] editing/inserting/4960120-1.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] editing/pasteboard/pasting-tabs.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/block/float/overhanging-tall-block.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/dom/HTMLTextAreaElement/reset-textarea.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/basic-textareas-quirks.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/basic-textareas.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/form-element-geometry.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/linebox-overflow-in-textarea-padding.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/negativeLineHeight.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textAreaLineHeight.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-align.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-placeholder-pseudo-style.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-placeholder-visibility-1.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-placeholder-visibility-2.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-scroll-height.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-scrollbar.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-scrolled-type.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-setinnerhtml.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/forms/textarea-width.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/overflow/overflow-x-y.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/parser/entity-comment-in-textarea.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/parser/open-comment-in-textarea.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/repaint/textarea-set-disabled.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/replaced/width100percent-textarea.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/table/003.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/text/international/rtl-white-space-pre-wrap.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] fast/text/international/unicode-bidi-plaintext-in-textarea.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] tables/mozilla/bugs/bug194024.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] tables/mozilla/bugs/bug30559.html [ ImageOnlyFailure ]
+webkit.org/b/108383 [ Mac Win ] tables/mozilla/bugs/bug30692.html [ ImageOnlyFailure ]
+
 # Rebaseline required after https://webkit.org/b/31397
 webkit.org/b/107567 svg/batik/text/xmlSpace.svg [ Failure ] 
 webkit.org/b/107567 fast/text/capitalize-empty-generated-string.html [ Failure ] 

Modified: trunk/LayoutTests/platform/chromium-linux/editing/inserting/4960120-1-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/pasting-tabs-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/basic-textareas-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/form-element-geometry-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/negativeLineHeight-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-align-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-setinnerhtml-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/textarea-width-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/overflow/overflow-x-y-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/parser/entity-comment-in-textarea-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/table/003-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png


(Binary files differ)

Modified: trunk/Tools/ChangeLog (141330 => 141331)


--- trunk/Tools/ChangeLog	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/Tools/ChangeLog	2013-01-30 23:27:05 UTC (rev 141331)
@@ -1,3 +1,15 @@
+2013-01-30  Tony Chang  <t...@chromium.org>
+
+        [Chromium] Enable textarea resize corner for tests
+        https://bugs.webkit.org/show_bug.cgi?id=108385
+
+        Reviewed by Ojan Vafai.
+
+        We should test what we ship. Also, this makes us pass more tests in content_shell.
+
+        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
+        (WebTestRunner::WebPreferences::reset): Turn on resize corner.
+
 2013-01-30  Jochen Eisinger  <joc...@chromium.org>
 
         [chromium] move custom policy delegate to TestRunner library

Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp (141330 => 141331)


--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp	2013-01-30 23:22:25 UTC (rev 141330)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp	2013-01-30 23:27:05 UTC (rev 141331)
@@ -95,7 +95,7 @@
     offlineWebApplicationCacheEnabled = true;
     pluginsEnabled = true;
     shrinksStandaloneImagesToFit = false;
-    textAreasAreResizable = false;
+    textAreasAreResizable = true;
     userStyleSheetLocation = WebURL();
     usesPageCache = false;
     pageCacheSupportsPlugins = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to