Title: [141305] trunk/Source/_javascript_Core
- Revision
- 141305
- Author
- [email protected]
- Date
- 2013-01-30 14:16:25 -0800 (Wed, 30 Jan 2013)
Log Message
Objective-C API: exceptionHandler needs to be released in JSContext dealloc
https://bugs.webkit.org/show_bug.cgi?id=108378
Reviewed by Filip Pizlo.
JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc.
That sounds like the potential for a leak. It should be released.
* API/JSContext.mm:
(-[JSContext dealloc]):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSContext.mm (141304 => 141305)
--- trunk/Source/_javascript_Core/API/JSContext.mm 2013-01-30 21:55:30 UTC (rev 141304)
+++ trunk/Source/_javascript_Core/API/JSContext.mm 2013-01-30 22:16:25 UTC (rev 141305)
@@ -163,6 +163,7 @@
[m_wrapperMap release];
JSGlobalContextRelease(m_context);
[m_virtualMachine release];
+ [self.exceptionHandler release];
[super dealloc];
}
Modified: trunk/Source/_javascript_Core/ChangeLog (141304 => 141305)
--- trunk/Source/_javascript_Core/ChangeLog 2013-01-30 21:55:30 UTC (rev 141304)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-01-30 22:16:25 UTC (rev 141305)
@@ -1,3 +1,16 @@
+2013-01-30 Mark Hahnenberg <[email protected]>
+
+ Objective-C API: exceptionHandler needs to be released in JSContext dealloc
+ https://bugs.webkit.org/show_bug.cgi?id=108378
+
+ Reviewed by Filip Pizlo.
+
+ JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc.
+ That sounds like the potential for a leak. It should be released.
+
+ * API/JSContext.mm:
+ (-[JSContext dealloc]):
+
2013-01-30 Filip Pizlo <[email protected]>
REGRESSION(140504): pure CSE no longer matches things, 10% regression on Kraken
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes