Title: [141281] trunk/Source/WebCore
- Revision
- 141281
- Author
- jer.no...@apple.com
- Date
- 2013-01-30 10:20:30 -0800 (Wed, 30 Jan 2013)
Log Message
MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
https://bugs.webkit.org/show_bug.cgi?id=108237
Reviewed by Eric Carlson.
Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::addFileTypesToCache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141280 => 141281)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 17:55:48 UTC (rev 141280)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 18:20:30 UTC (rev 141281)
@@ -1,3 +1,15 @@
+2013-01-29 Jer Noble <jer.no...@apple.com>
+
+ MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
+ https://bugs.webkit.org/show_bug.cgi?id=108237
+
+ Reviewed by Eric Carlson.
+
+ Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::addFileTypesToCache):
+
2013-01-30 Florin Malita <fmal...@chromium.org>
Do not restart the matched properties cache timer if active
Modified: trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm (141280 => 141281)
--- trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm 2013-01-30 17:55:48 UTC (rev 141280)
+++ trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm 2013-01-30 18:20:30 UTC (rev 141281)
@@ -1476,8 +1476,15 @@
Vector<String> typesForExtension = MIMETypeRegistry::getMediaMIMETypesForExtension(ext);
unsigned count = typesForExtension.size();
for (unsigned ndx = 0; ndx < count; ++ndx) {
- if (!cache.contains(typesForExtension[ndx]))
- cache.add(typesForExtension[ndx]);
+ String& type = typesForExtension[ndx];
+
+ // QTKit will return non-video MIME types which it claims to support, but which we
+ // do not support in the <video> element. Disclaim all non video/ or audio/ types.
+ if (!type.startsWith("video/") && !type.startsWith("audio/"))
+ continue;
+
+ if (!cache.contains(type))
+ cache.add(type);
}
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
