Title: [141270] trunk/Source/WebCore
- Revision
- 141270
- Author
- [email protected]
- Date
- 2013-01-30 07:12:28 -0800 (Wed, 30 Jan 2013)
Log Message
Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
https://bugs.webkit.org/show_bug.cgi?id=108331
Patch by Vladislav Kaznacheev <[email protected]> on 2013-01-30
Reviewed by Pavel Feldman.
This was a regression caused by https://bugs.webkit.org/show_bug.cgi?id=108181.
The splitter element did not get the correct class at the initialization.
* inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarPosition):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141269 => 141270)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 15:10:57 UTC (rev 141269)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 15:12:28 UTC (rev 141270)
@@ -1,3 +1,17 @@
+2013-01-30 Vladislav Kaznacheev <[email protected]>
+
+ Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
+ https://bugs.webkit.org/show_bug.cgi?id=108331
+
+ Reviewed by Pavel Feldman.
+
+ This was a regression caused by https://bugs.webkit.org/show_bug.cgi?id=108181.
+ The splitter element did not get the correct class at the initialization.
+
+ * inspector/front-end/SidebarView.js:
+ (WebInspector.SidebarView):
+ (WebInspector.SidebarView.prototype._updateSidebarPosition):
+
2013-01-30 Dmitry Zvorygin <[email protected]>
Web Inspector: Filters on Console panel
Modified: trunk/Source/WebCore/inspector/front-end/SidebarView.js (141269 => 141270)
--- trunk/Source/WebCore/inspector/front-end/SidebarView.js 2013-01-30 15:10:57 UTC (rev 141269)
+++ trunk/Source/WebCore/inspector/front-end/SidebarView.js 2013-01-30 15:12:28 UTC (rev 141270)
@@ -46,7 +46,7 @@
this._sidebarPosition = sidebarPosition || WebInspector.SidebarView.SidebarPosition.Start;
this.setSecondIsSidebar(this._sidebarPosition === WebInspector.SidebarView.SidebarPosition.End);
- this._updateSidebarPosition();
+ this._updateSidebarPosition(true);
}
WebInspector.SidebarView.EventTypes = {
@@ -98,13 +98,16 @@
this._autoOrientation = on;
},
- _updateSidebarPosition: function()
+ /**
+ * @param {boolean=} force
+ */
+ _updateSidebarPosition: function(force)
{
var verticalSplit = true;
if (this._autoOrientation)
verticalSplit = this.element.offsetHeight < this.element.offsetWidth;
- if (verticalSplit === this.isVertical())
+ if (!force && verticalSplit === this.isVertical())
return;
if (this._sidebarPosition === WebInspector.SidebarView.SidebarPosition.Start) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes