Title: [141107] trunk/Source/WebKit/qt
Revision
141107
Author
michael.brun...@digia.com
Date
2013-01-29 06:48:41 -0800 (Tue, 29 Jan 2013)

Log Message

[Qt][WK1] Fix QObject Bridge tests expected output.
https://bugs.webkit.org/show_bug.cgi?id=107827

Reviewed by Simon Hausmann.

The "not a function" TypeError now includes the call that caused the error.
Correct expected values accordingly.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):

Modified Paths

Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (141106 => 141107)


--- trunk/Source/WebKit/qt/ChangeLog	2013-01-29 14:37:49 UTC (rev 141106)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-01-29 14:48:41 UTC (rev 141107)
@@ -1,3 +1,16 @@
+2013-01-29  Michael BrĂ¼ning  <michael.brun...@digia.com>
+
+        [Qt][WK1] Fix QObject Bridge tests expected output.
+        https://bugs.webkit.org/show_bug.cgi?id=107827
+
+        Reviewed by Simon Hausmann.
+
+        The "not a function" TypeError now includes the call that caused the error.
+        Correct expected values accordingly.
+
+        * tests/qobjectbridge/tst_qobjectbridge.cpp:
+        (tst_QObjectBridge::connectAndDisconnect):
+
 2013-01-28  Huang Dongsung  <luxte...@company100.net>
 
         [TexMap] Enable debug borders and repaint counter via Settings.

Modified: trunk/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp (141106 => 141107)


--- trunk/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp	2013-01-29 14:37:49 UTC (rev 141106)
+++ trunk/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp	2013-01-29 14:48:41 UTC (rev 141107)
@@ -1572,26 +1572,26 @@
         QString type;
         QString ret = evalJS("(function() { }).connect()", type);
         QCOMPARE(type, sError);
-        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
+        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()')"));
     }
     {
         QString type;
         QString ret = evalJS("var o = { }; o.connect = Function.prototype.connect;  o.connect()", type);
         QCOMPARE(type, sError);
-        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
+        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating 'o.connect()')"));
     }
 
     {
         QString type;
         QString ret = evalJS("(function() { }).connect(123)", type);
         QCOMPARE(type, sError);
-        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
+        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect(123)')"));
     }
     {
         QString type;
         QString ret = evalJS("var o = { }; o.connect = Function.prototype.connect;  o.connect(123)", type);
         QCOMPARE(type, sError);
-        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
+        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating 'o.connect(123)')"));
     }
 
     {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to