Title: [141067] trunk/Source/WebCore
Revision
141067
Author
commit-qu...@webkit.org
Date
2013-01-28 23:48:48 -0800 (Mon, 28 Jan 2013)

Log Message

[Texmap] Refactor code related to debug border and repaint count.
https://bugs.webkit.org/show_bug.cgi?id=105787

Patch by Huang Dongsung <luxte...@company100.net> on 2013-01-28
Reviewed by Noam Rosenthal.

It is a follow-up patch not to change layout test results.

The previous patch sets GraphicsLayer::m_usingTiledLayer to true when using a
backing store. When the variable is true, dumpLayer() adds (usingTiledLayer 1),
but most of ports don't set m_usingTiledLayer to true. So we don't use
m_usingTiledLayer to match the test results of other ports.

After this patch, Texture Mapper draws debug visuals for a tiled backing
with different color from safari.

No new tests. Debug feature, not covered in tests.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141066 => 141067)


--- trunk/Source/WebCore/ChangeLog	2013-01-29 07:47:20 UTC (rev 141066)
+++ trunk/Source/WebCore/ChangeLog	2013-01-29 07:48:48 UTC (rev 141067)
@@ -1,3 +1,25 @@
+2013-01-28  Huang Dongsung  <luxte...@company100.net>
+
+        [Texmap] Refactor code related to debug border and repaint count.
+        https://bugs.webkit.org/show_bug.cgi?id=105787
+
+        Reviewed by Noam Rosenthal.
+
+        It is a follow-up patch not to change layout test results.
+
+        The previous patch sets GraphicsLayer::m_usingTiledLayer to true when using a
+        backing store. When the variable is true, dumpLayer() adds (usingTiledLayer 1),
+        but most of ports don't set m_usingTiledLayer to true. So we don't use
+        m_usingTiledLayer to match the test results of other ports.
+
+        After this patch, Texture Mapper draws debug visuals for a tiled backing
+        with different color from safari.
+
+        No new tests. Debug feature, not covered in tests.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):
+
 2013-01-28  Elliott Sprehn  <espr...@chromium.org>
 
         Handle createShadowSubtree inside of ensureUserAgentShadowRoot

Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (141066 => 141067)


--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-01-29 07:47:20 UTC (rev 141066)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-01-29 07:48:48 UTC (rev 141067)
@@ -413,8 +413,8 @@
     if (!m_hasOwnBackingStore)
         return;
 
-    m_usingTiledLayer = shouldHaveBackingStore();
-    updateDebugIndicators();
+    if (isShowingDebugBorder())
+        updateDebugIndicators();
 
     // When this has its own backing store (e.g. Qt WK1), update the repaint count before calling TextureMapperLayer::flushCompositingStateForThisLayerOnly().
     bool needsToRepaint = shouldHaveBackingStore() && (m_needsDisplay || !m_needsDisplayRect.isEmpty());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to