Title: [141007] trunk/Source/WebCore
- Revision
- 141007
- Author
- t...@chromium.org
- Date
- 2013-01-28 14:06:01 -0800 (Mon, 28 Jan 2013)
Log Message
"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=108089
Reviewed by Ojan Vafai.
Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
These warnings are showing up on the main Chromium waterfall too:
http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio
No new tests, this is a build change.
* WebCore.gyp/WebCore.gyp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141006 => 141007)
--- trunk/Source/WebCore/ChangeLog 2013-01-28 21:47:44 UTC (rev 141006)
+++ trunk/Source/WebCore/ChangeLog 2013-01-28 22:06:01 UTC (rev 141007)
@@ -1,3 +1,18 @@
+2013-01-28 Tony Chang <t...@chromium.org>
+
+ "clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
+ https://bugs.webkit.org/show_bug.cgi?id=108089
+
+ Reviewed by Ojan Vafai.
+
+ Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
+ These warnings are showing up on the main Chromium waterfall too:
+ http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio
+
+ No new tests, this is a build change.
+
+ * WebCore.gyp/WebCore.gyp:
+
2013-01-28 Elliott Sprehn <espr...@chromium.org>
Move hasAuthorShadowRoot to Element
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (141006 => 141007)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-28 21:47:44 UTC (rev 141006)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-28 22:06:01 UTC (rev 141007)
@@ -240,14 +240,9 @@
'gperf_exe': 'gperf',
'bison_exe': 'bison',
- 'conditions': [
- # We specify a preprocess so it happens locally and won't get distributed to goma.
- ['OS=="mac" or OS=="ios"', {
- 'preprocessor': '--preprocessor "/usr/bin/clang -E -P -x c++"'
- },{
- 'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
- }]
- ],
+ # We specify a preprocess so it happens locally and won't get distributed to goma.
+ # FIXME: /usr/bin/gcc won't exist on OSX forever. We want to use /usr/bin/clang once we require Xcode 4.x.
+ 'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
}],
['use_x11==1 or OS=="android"', {
'webcore_include_dirs': [
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
