- Revision
- 141005
- Author
- espr...@chromium.org
- Date
- 2013-01-28 13:45:11 -0800 (Mon, 28 Jan 2013)
Log Message
Move hasAuthorShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108071
Reviewed by Dimitri Glazkov.
Move hasAuthorShadowRoot to Element and get rid of unneccesary booleans
in HTMLProgressElement and HTMLMeterElement. Also get rid of
ShadowRoot::isAccessible since it obfuscates what's actually happening
inside of Element::shadowRoot().
No new tests, just refactoring.
* dom/Element.cpp:
(WebCore::Element::shadowRoot):
(WebCore::Element::hasAuthorShadowRoot):
* dom/Element.h:
(Element):
* dom/ShadowRoot.h:
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
* html/HTMLMeterElement.h:
(HTMLMeterElement):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
* html/HTMLProgressElement.h:
(HTMLProgressElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141004 => 141005)
--- trunk/Source/WebCore/ChangeLog 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/ChangeLog 2013-01-28 21:45:11 UTC (rev 141005)
@@ -1,5 +1,34 @@
2013-01-28 Elliott Sprehn <espr...@chromium.org>
+ Move hasAuthorShadowRoot to Element
+ https://bugs.webkit.org/show_bug.cgi?id=108071
+
+ Reviewed by Dimitri Glazkov.
+
+ Move hasAuthorShadowRoot to Element and get rid of unneccesary booleans
+ in HTMLProgressElement and HTMLMeterElement. Also get rid of
+ ShadowRoot::isAccessible since it obfuscates what's actually happening
+ inside of Element::shadowRoot().
+
+ No new tests, just refactoring.
+
+ * dom/Element.cpp:
+ (WebCore::Element::shadowRoot):
+ (WebCore::Element::hasAuthorShadowRoot):
+ * dom/Element.h:
+ (Element):
+ * dom/ShadowRoot.h:
+ * html/HTMLMeterElement.cpp:
+ (WebCore::HTMLMeterElement::HTMLMeterElement):
+ * html/HTMLMeterElement.h:
+ (HTMLMeterElement):
+ * html/HTMLProgressElement.cpp:
+ (WebCore::HTMLProgressElement::HTMLProgressElement):
+ * html/HTMLProgressElement.h:
+ (HTMLProgressElement):
+
+2013-01-28 Elliott Sprehn <espr...@chromium.org>
+
Move ensureUserAgentShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108070
Modified: trunk/Source/WebCore/dom/Element.cpp (141004 => 141005)
--- trunk/Source/WebCore/dom/Element.cpp 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/dom/Element.cpp 2013-01-28 21:45:11 UTC (rev 141005)
@@ -1471,9 +1471,9 @@
if (!elementShadow)
return 0;
ShadowRoot* shadowRoot = elementShadow->youngestShadowRoot();
- if (!shadowRoot->isAccessible())
- return 0;
- return shadowRoot;
+ if (shadowRoot->type() == ShadowRoot::AuthorShadowRoot)
+ return shadowRoot;
+ return 0;
}
ShadowRoot* Element::userAgentShadowRoot() const
Modified: trunk/Source/WebCore/dom/Element.h (141004 => 141005)
--- trunk/Source/WebCore/dom/Element.h 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/dom/Element.h 2013-01-28 21:45:11 UTC (rev 141005)
@@ -293,6 +293,7 @@
PassRefPtr<ShadowRoot> createShadowRoot(ExceptionCode&);
ShadowRoot* shadowRoot() const;
+ bool hasAuthorShadowRoot() const { return shadowRoot(); }
virtual void willAddAuthorShadowRoot() { }
virtual bool areAuthorShadowsAllowed() const { return true; }
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (141004 => 141005)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2013-01-28 21:45:11 UTC (rev 141005)
@@ -93,7 +93,6 @@
ScopeContentDistribution* ensureScopeDistribution();
ShadowRootType type() const { return m_isAuthorShadowRoot ? AuthorShadowRoot : UserAgentShadowRoot; }
- bool isAccessible() const { return type() == AuthorShadowRoot; }
PassRefPtr<Node> cloneNode(bool, ExceptionCode&);
Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (141004 => 141005)
--- trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-01-28 21:45:11 UTC (rev 141005)
@@ -43,7 +43,6 @@
HTMLMeterElement::HTMLMeterElement(const QualifiedName& tagName, Document* document)
: LabelableElement(tagName, document)
- , m_hasAuthorShadowRoot(false)
{
ASSERT(hasTagName(meterTag));
}
@@ -225,11 +224,6 @@
render->updateFromElement();
}
-void HTMLMeterElement::willAddAuthorShadowRoot()
-{
- m_hasAuthorShadowRoot = true;
-}
-
RenderMeter* HTMLMeterElement::renderMeter() const
{
if (renderer() && renderer()->isMeter())
Modified: trunk/Source/WebCore/html/HTMLMeterElement.h (141004 => 141005)
--- trunk/Source/WebCore/html/HTMLMeterElement.h 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/html/HTMLMeterElement.h 2013-01-28 21:45:11 UTC (rev 141005)
@@ -39,8 +39,6 @@
GaugeRegionEvenLessGood
};
- bool hasAuthorShadowRoot() const { return m_hasAuthorShadowRoot; }
-
double min() const;
void setMin(double, ExceptionCode&);
@@ -68,7 +66,6 @@
HTMLMeterElement(const QualifiedName&, Document*);
virtual ~HTMLMeterElement();
- virtual void willAddAuthorShadowRoot() OVERRIDE;
virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
RenderMeter* renderMeter() const;
@@ -85,7 +82,6 @@
void createShadowSubtree();
RefPtr<MeterValueElement> m_value;
- bool m_hasAuthorShadowRoot;
};
inline bool isHTMLMeterElement(Node* node)
Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (141004 => 141005)
--- trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-01-28 21:45:11 UTC (rev 141005)
@@ -44,7 +44,6 @@
HTMLProgressElement::HTMLProgressElement(const QualifiedName& tagName, Document* document)
: LabelableElement(tagName, document)
, m_value(0)
- , m_hasAuthorShadowRoot(false)
{
ASSERT(hasTagName(progressTag));
}
@@ -83,11 +82,6 @@
return static_cast<RenderProgress*>(renderObject);
}
-void HTMLProgressElement::willAddAuthorShadowRoot()
-{
- m_hasAuthorShadowRoot = true;
-}
-
bool HTMLProgressElement::supportsFocus() const
{
return HTMLElement::supportsFocus() && !disabled();
Modified: trunk/Source/WebCore/html/HTMLProgressElement.h (141004 => 141005)
--- trunk/Source/WebCore/html/HTMLProgressElement.h 2013-01-28 21:42:22 UTC (rev 141004)
+++ trunk/Source/WebCore/html/HTMLProgressElement.h 2013-01-28 21:45:11 UTC (rev 141005)
@@ -36,8 +36,6 @@
static PassRefPtr<HTMLProgressElement> create(const QualifiedName&, Document*);
- bool hasAuthorShadowRoot() const { return m_hasAuthorShadowRoot; }
-
double value() const;
void setValue(double, ExceptionCode&);
@@ -54,7 +52,6 @@
HTMLProgressElement(const QualifiedName&, Document*);
virtual ~HTMLProgressElement();
- virtual void willAddAuthorShadowRoot() OVERRIDE;
virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
virtual bool supportLabels() const OVERRIDE { return true; }
@@ -73,7 +70,6 @@
void createShadowSubtree();
ProgressValueElement* m_value;
- bool m_hasAuthorShadowRoot;
};
inline bool isHTMLProgressElement(Node* node)
