Title: [140925] trunk/Source/WebCore
- Revision
- 140925
- Author
- t...@chromium.org
- Date
- 2013-01-26 22:39:38 -0800 (Sat, 26 Jan 2013)
Log Message
[chromium] Don't use goma to preprocess bindings idl files
https://bugs.webkit.org/show_bug.cgi?id=107984
Reviewed by Adam Barth.
On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.
No new tests, this is a build change.
* WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140924 => 140925)
--- trunk/Source/WebCore/ChangeLog 2013-01-27 05:32:53 UTC (rev 140924)
+++ trunk/Source/WebCore/ChangeLog 2013-01-27 06:39:38 UTC (rev 140925)
@@ -1,3 +1,18 @@
+2013-01-26 Tony Chang <t...@chromium.org>
+
+ [chromium] Don't use goma to preprocess bindings idl files
+ https://bugs.webkit.org/show_bug.cgi?id=107984
+
+ Reviewed by Adam Barth.
+
+ On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
+ On my machine, this drops the bindings generation from 137s to 24s when
+ using goma and -j400.
+
+ No new tests, this is a build change.
+
+ * WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
+
2013-01-26 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r140880.
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (140924 => 140925)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-27 05:32:53 UTC (rev 140924)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-27 06:39:38 UTC (rev 140925)
@@ -239,8 +239,15 @@
'perl_exe': 'perl',
'gperf_exe': 'gperf',
'bison_exe': 'bison',
- # Without one specified, the scripts default to 'gcc'.
- 'preprocessor': '',
+
+ 'conditions': [
+ # We specify a preprocess so it happens locally and won't get distributed to goma.
+ ['OS=="mac" or OS=="ios"', {
+ 'preprocessor': '--preprocessor "/usr/bin/clang -E -P -x c++"'
+ },{
+ 'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
+ }]
+ ],
}],
['use_x11==1 or OS=="android"', {
'webcore_include_dirs': [
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
