Title: [140709] trunk
- Revision
- 140709
- Author
- mk...@chromium.org
- Date
- 2013-01-24 12:40:23 -0800 (Thu, 24 Jan 2013)
Log Message
Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107816
Reviewed by Pavel Feldman.
Source/WebCore:
'console.debug' is currently aliased to 'console.log'. Since we now
render debug-level messages differently to log messages, we should use
the proper message level for 'console.debug'.
* page/Console.cpp:
(WebCore::Console::debug):
Replace the alias to 'console.log' with message creation at
DebugMessageLevel.
LayoutTests:
* inspector/console/console-tests-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
Rebaseline this test with the updated message level.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (140708 => 140709)
--- trunk/LayoutTests/ChangeLog 2013-01-24 20:35:15 UTC (rev 140708)
+++ trunk/LayoutTests/ChangeLog 2013-01-24 20:40:23 UTC (rev 140709)
@@ -1,3 +1,14 @@
+2013-01-24 Mike West <mk...@chromium.org>
+
+ Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
+ https://bugs.webkit.org/show_bug.cgi?id=107816
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/console/console-tests-expected.txt:
+ * inspector/extensions/extensions-console-expected.txt:
+ Rebaseline this test with the updated message level.
+
2013-01-24 Dima Gorbik <dgor...@apple.com>
Implement :past pseudo class for the WebVTT ::cue pseudo element
Modified: trunk/LayoutTests/inspector/console/console-tests-expected.txt (140708 => 140709)
--- trunk/LayoutTests/inspector/console/console-tests-expected.txt 2013-01-24 20:35:15 UTC (rev 140708)
+++ trunk/LayoutTests/inspector/console/console-tests-expected.txt 2013-01-24 20:40:23 UTC (rev 140709)
@@ -22,7 +22,7 @@
Tests that console logging dumps proper messages.
log console-tests.html:9 console-message console-log-level
-debug console-tests.html:10 console-message console-log-level
+debug console-tests.html:10 console-message console-debug-level
info console-tests.html:11 console-message console-log-level
warn console-tests.html:12 console-message console-warning-level
error console-tests.html:13 console-message console-error-level
Modified: trunk/LayoutTests/inspector/extensions/extensions-console-expected.txt (140708 => 140709)
--- trunk/LayoutTests/inspector/extensions/extensions-console-expected.txt 2013-01-24 20:35:15 UTC (rev 140708)
+++ trunk/LayoutTests/inspector/extensions/extensions-console-expected.txt 2013-01-24 20:40:23 UTC (rev 140709)
@@ -16,7 +16,7 @@
Running tests...
RUNNING TEST: extension_testAddConsoleMessages
log message extensions-console.html:46 console-message console-log-level
-debug message extensions-console.html:47 console-message console-log-level
+debug message extensions-console.html:47 console-message console-debug-level
warning message extensions-console.html:48 console-message console-warning-level
error message extensions-console.html:49 console-message console-error-level
log message with two parameters, an integer: 42 and a string: foo extensions-console.html:50 console-message console-log-level
@@ -35,7 +35,7 @@
}
1 : {
line : 47
- severity : "log"
+ severity : "debug"
text : "debug message"
url : .../extensions-console.html
}
@@ -94,7 +94,7 @@
{
0 : {
line : 47
- severity : "log"
+ severity : "debug"
text : "debug message"
url : .../extensions-console.html
}
Modified: trunk/Source/WebCore/ChangeLog (140708 => 140709)
--- trunk/Source/WebCore/ChangeLog 2013-01-24 20:35:15 UTC (rev 140708)
+++ trunk/Source/WebCore/ChangeLog 2013-01-24 20:40:23 UTC (rev 140709)
@@ -1,3 +1,19 @@
+2013-01-24 Mike West <mk...@chromium.org>
+
+ Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
+ https://bugs.webkit.org/show_bug.cgi?id=107816
+
+ Reviewed by Pavel Feldman.
+
+ 'console.debug' is currently aliased to 'console.log'. Since we now
+ render debug-level messages differently to log messages, we should use
+ the proper message level for 'console.debug'.
+
+ * page/Console.cpp:
+ (WebCore::Console::debug):
+ Replace the alias to 'console.log' with message creation at
+ DebugMessageLevel.
+
2013-01-24 Dima Gorbik <dgor...@apple.com>
Implement :past pseudo class for the WebVTT ::cue pseudo element
Modified: trunk/Source/WebCore/page/Console.cpp (140708 => 140709)
--- trunk/Source/WebCore/page/Console.cpp 2013-01-24 20:35:15 UTC (rev 140708)
+++ trunk/Source/WebCore/page/Console.cpp 2013-01-24 20:40:23 UTC (rev 140709)
@@ -233,8 +233,7 @@
void Console::debug(ScriptState* state, PassRefPtr<ScriptArguments> arguments)
{
- // In Firebug, console.debug has the same behavior as console.log. So we'll do the same.
- log(state, arguments);
+ internalAddMessage(page(), LogMessageType, DebugMessageLevel, state, arguments);
}
void Console::error(ScriptState* state, PassRefPtr<ScriptArguments> arguments)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
