Title: [140609] trunk/Source/WebCore
Revision
140609
Author
[email protected]
Date
2013-01-23 16:21:18 -0800 (Wed, 23 Jan 2013)

Log Message

Stop the background-parser during HTMLDocumentParser::detatch to prevent crashes/asserts
https://bugs.webkit.org/show_bug.cgi?id=107751

Reviewed by Tony Gentilcore.

This appears to fix the 2 intermitent crashers we were seeing while
running fast/parser.  And definitely fixes 8 ASSERTs seen using a Debug build.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::detach):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140608 => 140609)


--- trunk/Source/WebCore/ChangeLog	2013-01-24 00:09:59 UTC (rev 140608)
+++ trunk/Source/WebCore/ChangeLog	2013-01-24 00:21:18 UTC (rev 140609)
@@ -1,3 +1,16 @@
+2013-01-23  Eric Seidel  <[email protected]>
+
+        Stop the background-parser during HTMLDocumentParser::detatch to prevent crashes/asserts
+        https://bugs.webkit.org/show_bug.cgi?id=107751
+
+        Reviewed by Tony Gentilcore.
+
+        This appears to fix the 2 intermitent crashers we were seeing while
+        running fast/parser.  And definitely fixes 8 ASSERTs seen using a Debug build.
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::detach):
+
 2013-01-23  Hans Muller  <[email protected]>
 
         [CSS Exclusions] Add support for computing first included interval position for polygons

Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (140608 => 140609)


--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-01-24 00:09:59 UTC (rev 140608)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2013-01-24 00:21:18 UTC (rev 140609)
@@ -121,6 +121,10 @@
 
 void HTMLDocumentParser::detach()
 {
+#if ENABLE(THREADED_HTML_PARSER)
+    if (m_haveBackgroundParser)
+        stopBackgroundParser();
+#endif
     DocumentParser::detach();
     if (m_scriptRunner)
         m_scriptRunner->detach();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to