Title: [140519] trunk/Source/WebCore
Revision
140519
Author
[email protected]
Date
2013-01-23 00:34:16 -0800 (Wed, 23 Jan 2013)

Log Message

[TexMap] Don't call GraphicsLayer::setNeedsDisplay() from TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=107629

Patch by Huang Dongsung <[email protected]> on 2013-01-23
Reviewed by Noam Rosenthal.

We are removing the dependency on GraphicsLayer from TextureMapperLayer.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

No new tests, refactoring only.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140518 => 140519)


--- trunk/Source/WebCore/ChangeLog	2013-01-23 08:32:08 UTC (rev 140518)
+++ trunk/Source/WebCore/ChangeLog	2013-01-23 08:34:16 UTC (rev 140519)
@@ -1,3 +1,22 @@
+2013-01-23  Huang Dongsung  <[email protected]>
+
+        [TexMap] Don't call GraphicsLayer::setNeedsDisplay() from TextureMapperLayer.
+        https://bugs.webkit.org/show_bug.cgi?id=107629
+
+        Reviewed by Noam Rosenthal.
+
+        We are removing the dependency on GraphicsLayer from TextureMapperLayer.
+
+        This is in preparation for refactoring TextureMapper to work in an actor
+        model (http://webkit.org/b/103854).
+
+        No new tests, refactoring only.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::setDrawsContent):
+        * platform/graphics/texmap/TextureMapperLayer.cpp:
+        (WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
+
 2013-01-23  No'am Rosenthal  <[email protected]>
 
         [Texmap] Rename TextureMapperShaderManager.* TextureMapperShaderProgram.*

Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (140518 => 140519)


--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-01-23 08:32:08 UTC (rev 140518)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-01-23 08:34:16 UTC (rev 140519)
@@ -280,6 +280,9 @@
         return;
     notifyChange(TextureMapperLayer::DrawsContentChange);
     GraphicsLayer::setDrawsContent(value);
+
+    if (value && m_hasOwnBackingStore)
+        setNeedsDisplay();
 }
 
 /* \reimp (GraphicsLayer.h)

Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (140518 => 140519)


--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2013-01-23 08:32:08 UTC (rev 140518)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2013-01-23 08:34:16 UTC (rev 140519)
@@ -388,9 +388,6 @@
     if (changeMask & ChildrenChange)
         setChildren(graphicsLayer->children());
 
-    if ((changeMask & DrawsContentChange) && graphicsLayer->drawsContent())
-        graphicsLayer->setNeedsDisplay();
-
     if (changeMask & MaskLayerChange) {
        if (TextureMapperLayer* layer = toTextureMapperLayer(graphicsLayer->maskLayer()))
            layer->m_effectTarget = this;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to