Diff
Modified: trunk/Source/WebCore/ChangeLog (140400 => 140401)
--- trunk/Source/WebCore/ChangeLog 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/ChangeLog 2013-01-22 09:48:22 UTC (rev 140401)
@@ -1,3 +1,47 @@
+2013-01-22 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Make an Isolate parameter mandatory in toV8()
+ https://bugs.webkit.org/show_bug.cgi?id=107520
+
+ Reviewed by Adam Barth.
+
+ Now it's safe to remove an optional Isolate parameter.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/scripts/test/V8/V8Float64Array.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventTarget.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestException.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestInterface.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNode.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestObj.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+ (WebCore::toV8):
+ * css/MediaQueryListListener.cpp:
+ (WebCore::MediaQueryListListener::queryChanged):
+ * testing/v8/WebCoreTestSupport.cpp:
+ (WebCoreTestSupport::injectInternalsObject):
+
2013-01-22 Mihnea Ovidenie <mih...@adobe.com>
[CSS Regions] min-max height will not trigger a relayout when set on a region with auto-height
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-01-22 09:48:22 UTC (rev 140401)
@@ -532,7 +532,7 @@
die "Must have custom toV8\n" if !$customWrap;
push(@headerContent, <<END);
class ${nativeType};
-v8::Handle<v8::Value> toV8(${nativeType}*, v8::Handle<v8::Object> creationContext, v8::Isolate* = 0);
+v8::Handle<v8::Value> toV8(${nativeType}*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
template<class HolderContainer, class Wrappable>
inline v8::Handle<v8::Value> toV8Fast(${nativeType}* impl, const HolderContainer& container, Wrappable*)
@@ -563,7 +563,7 @@
push(@headerContent, <<END);
-inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -594,7 +594,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< ${nativeType} > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< ${nativeType} > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -56,7 +56,7 @@
v8::Handle<v8::Object> wrap(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);
-inline v8::Handle<v8::Value> toV8(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -83,7 +83,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< Float64Array > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< Float64Array > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -61,7 +61,7 @@
return V8TestActiveDOMObject::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -88,7 +88,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestActiveDOMObject > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestActiveDOMObject > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -60,7 +60,7 @@
return V8TestCustomNamedGetter::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -87,7 +87,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestCustomNamedGetter > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestCustomNamedGetter > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -61,7 +61,7 @@
return V8TestEventConstructor::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -88,7 +88,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventConstructor > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventConstructor > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -62,7 +62,7 @@
return V8TestEventTarget::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -89,7 +89,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventTarget > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventTarget > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -59,7 +59,7 @@
return V8TestException::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -86,7 +86,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestException > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestException > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -66,7 +66,7 @@
return V8TestInterface::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -93,7 +93,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestInterface > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestInterface > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -59,7 +59,7 @@
return V8TestMediaQueryListListener::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -86,7 +86,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestMediaQueryListListener > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestMediaQueryListListener > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -66,7 +66,7 @@
return V8TestNamedConstructor::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -93,7 +93,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNamedConstructor > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNamedConstructor > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -60,7 +60,7 @@
return V8TestNode::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -87,7 +87,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -65,7 +65,7 @@
return V8TestObj::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -92,7 +92,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestObj > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestObj > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -64,7 +64,7 @@
return V8TestOverloadedConstructors::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -91,7 +91,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestOverloadedConstructors > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestOverloadedConstructors > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h (140400 => 140401)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2013-01-22 09:48:22 UTC (rev 140401)
@@ -62,7 +62,7 @@
return V8TestSerializedScriptValueInterface::createWrapper(impl, creationContext, isolate);
}
-inline v8::Handle<v8::Value> toV8(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (UNLIKELY(!impl))
return v8NullWithCheck(isolate);
@@ -89,7 +89,7 @@
return toV8Fast(impl.get(), container, wrappable);
}
-inline v8::Handle<v8::Value> toV8(PassRefPtr< TestSerializedScriptValueInterface > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Value> toV8(PassRefPtr< TestSerializedScriptValueInterface > impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
return toV8(impl.get(), creationContext, isolate);
}
Modified: trunk/Source/WebCore/css/MediaQueryListListener.cpp (140400 => 140401)
--- trunk/Source/WebCore/css/MediaQueryListListener.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/css/MediaQueryListListener.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -42,7 +42,7 @@
if (context.IsEmpty())
return; // JS may not be enabled.
v8::Context::Scope scope(context);
- callback.appendArgument(toV8(query, v8::Handle<v8::Object>()));
+ callback.appendArgument(toV8(query, v8::Handle<v8::Object>(), context->GetIsolate()));
#endif
callback.call();
}
Modified: trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp (140400 => 140401)
--- trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -46,7 +46,7 @@
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
if (scriptContext->isDocument())
- context->Global()->Set(v8::String::New(Internals::internalsId), toV8(Internals::create(static_cast<Document*>(scriptContext)), v8::Handle<v8::Object>()));
+ context->Global()->Set(v8::String::New(Internals::internalsId), toV8(Internals::create(static_cast<Document*>(scriptContext)), v8::Handle<v8::Object>(), context->GetIsolate()));
}
void resetInternalsObject(v8::Local<v8::Context> context)
Modified: trunk/Source/WebKit/chromium/ChangeLog (140400 => 140401)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-22 09:48:22 UTC (rev 140401)
@@ -1,3 +1,25 @@
+2013-01-22 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Make an Isolate parameter mandatory in toV8()
+ https://bugs.webkit.org/show_bug.cgi?id=107520
+
+ Reviewed by Adam Barth.
+
+ Now it's safe to remove an optional Isolate parameter.
+
+ No tests. No change in behavior.
+
+ * src/InspectorFrontendClientImpl.cpp:
+ (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
+ * src/WebArrayBuffer.cpp:
+ (WebKit::WebArrayBuffer::toV8Value):
+ * src/WebBlob.cpp:
+ (WebKit::WebBlob::toV8Value):
+ * src/WebFrameImpl.cpp:
+ (WebKit::WebFrameImpl::createFileSystem):
+ (WebKit::WebFrameImpl::createSerializableFileSystem):
+ (WebKit::WebFrameImpl::createFileEntry):
+
2013-01-21 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed. Rolled Chromium DEPS to r177962. Requested by
Modified: trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp (140400 => 140401)
--- trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -68,7 +68,7 @@
ASSERT(!m_frontendHost);
m_frontendHost = InspectorFrontendHost::create(this, m_frontendPage);
- v8::Handle<v8::Value> frontendHostObj = toV8(m_frontendHost.get(), v8::Handle<v8::Object>());
+ v8::Handle<v8::Value> frontendHostObj = toV8(m_frontendHost.get(), v8::Handle<v8::Object>(), frameContext->GetIsolate());
v8::Handle<v8::Object> global = frameContext->Global();
global->Set(v8::String::New("InspectorFrontendHost"), frontendHostObj);
Modified: trunk/Source/WebKit/chromium/src/WebArrayBuffer.cpp (140400 => 140401)
--- trunk/Source/WebKit/chromium/src/WebArrayBuffer.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebKit/chromium/src/WebArrayBuffer.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -74,7 +74,7 @@
{
if (!m_private.get())
return v8::Handle<v8::Value>();
- return toV8(m_private.get(), v8::Handle<v8::Object>());
+ return toV8(m_private.get(), v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
WebArrayBuffer* WebArrayBuffer::createFromV8Value(v8::Handle<v8::Value> value)
Modified: trunk/Source/WebKit/chromium/src/WebBlob.cpp (140400 => 140401)
--- trunk/Source/WebKit/chromium/src/WebBlob.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebKit/chromium/src/WebBlob.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -63,7 +63,7 @@
{
if (!m_private.get())
return v8::Handle<v8::Value>();
- return toV8(m_private.get(), v8::Handle<v8::Object>());
+ return toV8(m_private.get(), v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
#endif
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (140400 => 140401)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-01-22 09:43:45 UTC (rev 140400)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-01-22 09:48:22 UTC (rev 140401)
@@ -912,7 +912,7 @@
v8::Handle<v8::Value> WebFrameImpl::createFileSystem(WebFileSystem::Type type, const WebString& name, const WebString& path)
{
ASSERT(frame());
- return toV8(DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create()), v8::Handle<v8::Object>());
+ return toV8(DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create()), v8::Handle<v8::Object>(), frame()->script()->currentWorldContext()->GetIsolate());
}
v8::Handle<v8::Value> WebFrameImpl::createSerializableFileSystem(WebFileSystem::Type type, const WebString& name, const WebString& path)
@@ -920,7 +920,7 @@
ASSERT(frame());
RefPtr<DOMFileSystem> fileSystem = DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create());
fileSystem->makeClonable();
- return toV8(fileSystem.release(), v8::Handle<v8::Object>());
+ return toV8(fileSystem.release(), v8::Handle<v8::Object>(), frame()->script()->currentWorldContext()->GetIsolate());
}
v8::Handle<v8::Value> WebFrameImpl::createFileEntry(WebFileSystem::Type type, const WebString& fileSystemName, const WebString& fileSystemPath, const WebString& filePath, bool isDirectory)
@@ -929,8 +929,8 @@
RefPtr<DOMFileSystemBase> fileSystem = DOMFileSystem::create(frame()->document(), fileSystemName, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, fileSystemPath.utf8().data()), AsyncFileSystemChromium::create());
if (isDirectory)
- return toV8(DirectoryEntry::create(fileSystem, filePath), v8::Handle<v8::Object>());
- return toV8(FileEntry::create(fileSystem, filePath), v8::Handle<v8::Object>());
+ return toV8(DirectoryEntry::create(fileSystem, filePath), v8::Handle<v8::Object>(), frame()->script()->currentWorldContext()->GetIsolate());
+ return toV8(FileEntry::create(fileSystem, filePath), v8::Handle<v8::Object>(), frame()->script()->currentWorldContext()->GetIsolate());
}
void WebFrameImpl::reload(bool ignoreCache)
