Title: [140128] trunk/Source/WebKit/blackberry
- Revision
- 140128
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-18 04:50:17 -0800 (Fri, 18 Jan 2013)
Log Message
[BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
https://bugs.webkit.org/show_bug.cgi?id=107215
Patch by Andrew Lo <a...@rim.com> on 2013-01-18
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
Internal PR276660
Render jobs should not be performed if the backing store is inactive.
This occured when the browser was invoked, causing a web page to be made
visible before the surface pool was resumed.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (140127 => 140128)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2013-01-18 12:37:08 UTC (rev 140127)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2013-01-18 12:50:17 UTC (rev 140128)
@@ -542,7 +542,7 @@
bool BackingStorePrivate::shouldPerformRenderJobs() const
{
- return (m_webPage->isVisible() || shouldDirectRenderingToWindow()) && !m_suspendRenderJobs && !m_suspendBackingStoreUpdates && !m_renderQueue->isEmpty(!m_suspendRegularRenderJobs);
+ return (isActive() || shouldDirectRenderingToWindow()) && !m_suspendRenderJobs && !m_suspendBackingStoreUpdates && !m_renderQueue->isEmpty(!m_suspendRegularRenderJobs);
}
bool BackingStorePrivate::shouldPerformRegularRenderJobs() const
Modified: trunk/Source/WebKit/blackberry/ChangeLog (140127 => 140128)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-01-18 12:37:08 UTC (rev 140127)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-01-18 12:50:17 UTC (rev 140128)
@@ -1,3 +1,20 @@
+2013-01-18 Andrew Lo <a...@rim.com>
+
+ [BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
+ https://bugs.webkit.org/show_bug.cgi?id=107215
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Jakob Petsovits.
+
+ Internal PR276660
+ Render jobs should not be performed if the backing store is inactive.
+
+ This occured when the browser was invoked, causing a web page to be made
+ visible before the surface pool was resumed.
+
+ * Api/BackingStore.cpp:
+ (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
+
2013-01-17 Yong Li <y...@rim.com>
[BlackBerry] InRegionScroller should notify client before it deletes all the scrollables
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
