Title: [139894] trunk/Source/WebCore
Revision
139894
Author
r...@google.com
Date
2013-01-16 10:32:46 -0800 (Wed, 16 Jan 2013)

Log Message

Use SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
https://bugs.webkit.org/show_bug.cgi?id=107016

Reviewed by James Robinson.

No new tests. existing tests exercise this code.

The default constructor is being deprecated, so this change is also part of that effort,
though it is a perf-improvement regardless, since we avoid making a new (temp) matrix.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139893 => 139894)


--- trunk/Source/WebCore/ChangeLog	2013-01-16 18:32:23 UTC (rev 139893)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 18:32:46 UTC (rev 139894)
@@ -1,3 +1,18 @@
+2013-01-16  Mike Reed  <r...@google.com>
+
+        Use SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
+        https://bugs.webkit.org/show_bug.cgi?id=107016
+
+        Reviewed by James Robinson.
+
+        No new tests. existing tests exercise this code.
+
+        The default constructor is being deprecated, so this change is also part of that effort,
+        though it is a perf-improvement regardless, since we avoid making a new (temp) matrix.
+
+        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
+        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
+
 2013-01-16  Ojan Vafai  <o...@chromium.org>
 
         RenderListMarker::computePreferredLogicalWidth should not be public

Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (139893 => 139894)


--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-01-16 18:32:23 UTC (rev 139893)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-01-16 18:32:46 UTC (rev 139894)
@@ -735,7 +735,7 @@
         m_layer->layer()->setPosition(FloatPoint::zero());
 
         m_layer->layer()->setAnchorPoint(FloatPoint(0.5f, 0.5f));
-        m_layer->layer()->setTransform(SkMatrix44());
+        m_layer->layer()->setTransform(SkMatrix44::I());
 
         // Set the old layer to opacity of 1. Further down we will set the opacity on the transform layer.
         m_layer->layer()->setOpacity(1);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to