Title: [139801] trunk/Source/WebKit/win
- Revision
- 139801
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-15 15:45:14 -0800 (Tue, 15 Jan 2013)
Log Message
Crash when saving history with no items in it.
https://bugs.webkit.org/show_bug.cgi?id=104261
Patch by pe...@outlook.com <pe...@outlook.com> on 2013-01-15
Reviewed by Darin Adler.
* WebHistory.cpp:
(WebHistory::saveHistoryGuts): Added null pointer check
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (139800 => 139801)
--- trunk/Source/WebKit/win/ChangeLog 2013-01-15 23:43:27 UTC (rev 139800)
+++ trunk/Source/WebKit/win/ChangeLog 2013-01-15 23:45:14 UTC (rev 139801)
@@ -1,3 +1,13 @@
+2013-01-15 pe...@outlook.com <pe...@outlook.com>
+
+ Crash when saving history with no items in it.
+ https://bugs.webkit.org/show_bug.cgi?id=104261
+
+ Reviewed by Darin Adler.
+
+ * WebHistory.cpp:
+ (WebHistory::saveHistoryGuts): Added null pointer check
+
2013-01-09 Levi Weintraub <le...@chromium.org>
Rolling out r139683. It broke a bunch of webkit_unit_tests.
Modified: trunk/Source/WebKit/win/WebHistory.cpp (139800 => 139801)
--- trunk/Source/WebKit/win/WebHistory.cpp 2013-01-15 23:43:27 UTC (rev 139800)
+++ trunk/Source/WebKit/win/WebHistory.cpp 2013-01-15 23:45:14 UTC (rev 139801)
@@ -381,6 +381,9 @@
RetainPtr<CFDataRef> data = ""
+ if (!data.get())
+ return E_FAIL;
+
RetainPtr<CFWriteStreamRef> stream(AdoptCF, CFWriteStreamCreateWithFile(kCFAllocatorDefault, url));
if (!stream)
return E_FAIL;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
