Title: [139723] trunk/Source/WebCore
- Revision
- 139723
- Author
- rn...@webkit.org
- Date
- 2013-01-15 00:30:34 -0800 (Tue, 15 Jan 2013)
Log Message
platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=106850
Reviewed by Chris Fleizach.
The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::supportsFocus):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::supportsFocus):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139722 => 139723)
--- trunk/Source/WebCore/ChangeLog 2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/ChangeLog 2013-01-15 08:30:34 UTC (rev 139723)
@@ -1,3 +1,21 @@
+2013-01-14 Ryosuke Niwa <rn...@webkit.org>
+
+ platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
+ https://bugs.webkit.org/show_bug.cgi?id=106850
+
+ Reviewed by Chris Fleizach.
+
+ The bug was caused by some callers of supportsFocus directly calling that of Node.
+ Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
+ called as needed.
+
+ * html/HTMLMeterElement.cpp:
+ (WebCore::HTMLMeterElement::supportsFocus):
+ * html/HTMLOutputElement.cpp:
+ (WebCore::HTMLOutputElement::supportsFocus):
+ * html/HTMLProgressElement.cpp:
+ (WebCore::HTMLProgressElement::supportsFocus):
+
2013-01-14 Dima Gorbik <dgor...@apple.com>
Implement ID selector matching for the WebVTT ::cue pseudo element
Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (139722 => 139723)
--- trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp 2013-01-15 08:30:34 UTC (rev 139723)
@@ -74,7 +74,7 @@
bool HTMLMeterElement::supportsFocus() const
{
- return Node::supportsFocus() && !disabled();
+ return HTMLElement::supportsFocus() && !disabled();
}
void HTMLMeterElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
Modified: trunk/Source/WebCore/html/HTMLOutputElement.cpp (139722 => 139723)
--- trunk/Source/WebCore/html/HTMLOutputElement.cpp 2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLOutputElement.cpp 2013-01-15 08:30:34 UTC (rev 139723)
@@ -58,7 +58,7 @@
bool HTMLOutputElement::supportsFocus() const
{
- return Node::supportsFocus() && !disabled();
+ return HTMLElement::supportsFocus() && !disabled();
}
void HTMLOutputElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (139722 => 139723)
--- trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp 2013-01-15 08:30:34 UTC (rev 139723)
@@ -90,7 +90,7 @@
bool HTMLProgressElement::supportsFocus() const
{
- return Node::supportsFocus() && !disabled();
+ return HTMLElement::supportsFocus() && !disabled();
}
void HTMLProgressElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
