Title: [139693] trunk/Source/WebCore
- Revision
- 139693
- Author
- o...@chromium.org
- Date
- 2013-01-14 17:19:14 -0800 (Mon, 14 Jan 2013)
Log Message
RenderListItem does not need to override computePreferredLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=106839
Reviewed by Levi Weintraub.
Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.
* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139692 => 139693)
--- trunk/Source/WebCore/ChangeLog 2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/ChangeLog 2013-01-15 01:19:14 UTC (rev 139693)
@@ -1,3 +1,18 @@
+2013-01-14 Ojan Vafai <o...@chromium.org>
+
+ RenderListItem does not need to override computePreferredLogicalWidth
+ https://bugs.webkit.org/show_bug.cgi?id=106839
+
+ Reviewed by Levi Weintraub.
+
+ Apparently there was a time when the list marker was considered part of
+ the list item's preferred width, but that is no longer the case.
+ This code was added in r3421. The code around preferred widths has change
+ a lot since then.
+
+ * rendering/RenderListItem.cpp:
+ * rendering/RenderListItem.h:
+
2013-01-14 Dima Gorbik <dgor...@apple.com>
Implement element type selectors for the WebVTT ::cue pseudo class
Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (139692 => 139693)
--- trunk/Source/WebCore/rendering/RenderListItem.cpp 2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp 2013-01-15 01:19:14 UTC (rev 139693)
@@ -274,15 +274,6 @@
}
}
-void RenderListItem::computePreferredLogicalWidths()
-{
- ASSERT(preferredLogicalWidthsDirty());
-
- updateMarkerLocation();
-
- RenderBlock::computePreferredLogicalWidths();
-}
-
void RenderListItem::layout()
{
StackStats::LayoutCheckPoint layoutCheckPoint;
Modified: trunk/Source/WebCore/rendering/RenderListItem.h (139692 => 139693)
--- trunk/Source/WebCore/rendering/RenderListItem.h 2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/rendering/RenderListItem.h 2013-01-15 01:19:14 UTC (rev 139693)
@@ -65,7 +65,6 @@
virtual void paint(PaintInfo&, const LayoutPoint&);
virtual void layout();
- virtual void computePreferredLogicalWidths();
void positionListMarker();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
