Title: [139680] trunk/Source/WebCore
Revision
139680
Author
o...@chromium.org
Date
2013-01-14 15:53:51 -0800 (Mon, 14 Jan 2013)

Log Message

Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
https://bugs.webkit.org/show_bug.cgi?id=106832

Reviewed by Levi Weintraub.

These are both called from locations that either set these bits themselves
or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139679 => 139680)


--- trunk/Source/WebCore/ChangeLog	2013-01-14 23:50:42 UTC (rev 139679)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 23:53:51 UTC (rev 139680)
@@ -1,3 +1,17 @@
+2013-01-14  Ojan Vafai  <o...@chromium.org>
+
+        Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
+        https://bugs.webkit.org/show_bug.cgi?id=106832
+
+        Reviewed by Levi Weintraub.
+
+        These are both called from locations that either set these bits themselves
+        or clearly don't need these bits set (e.g. computePreferredLogicalWidths).
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::splitColumn):
+        (WebCore::RenderTable::appendColumn):
+
 2013-01-14  Chris Rogers  <crog...@google.com>
 
         Switch AudioDestinationChromium over to new createAudioDevice() method

Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (139679 => 139680)


--- trunk/Source/WebCore/rendering/RenderTable.cpp	2013-01-14 23:50:42 UTC (rev 139679)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp	2013-01-14 23:53:51 UTC (rev 139680)
@@ -758,7 +758,6 @@
     }
 
     m_columnPos.grow(numEffCols() + 1);
-    setNeedsLayoutAndPrefWidthsRecalc();
 }
 
 void RenderTable::appendColumn(unsigned span)
@@ -780,7 +779,6 @@
     }
 
     m_columnPos.grow(numEffCols() + 1);
-    setNeedsLayoutAndPrefWidthsRecalc();
 }
 
 RenderTableCol* RenderTable::firstColumn() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to