Title: [139636] trunk/LayoutTests
- Revision
- 139636
- Author
- t...@chromium.org
- Date
- 2013-01-14 11:53:42 -0800 (Mon, 14 Jan 2013)
Log Message
Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
https://bugs.webkit.org/show_bug.cgi?id=106806
Reviewed by Levi Weintraub.
This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.
* editing/spelling/spellcheck-sequencenum-expected.txt:
* editing/spelling/spellcheck-sequencenum.html:
* platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139635 => 139636)
--- trunk/LayoutTests/ChangeLog 2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/ChangeLog 2013-01-14 19:53:42 UTC (rev 139636)
@@ -1,3 +1,18 @@
+2013-01-14 Tony Chang <t...@chromium.org>
+
+ Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
+ https://bugs.webkit.org/show_bug.cgi?id=106806
+
+ Reviewed by Levi Weintraub.
+
+ This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
+ the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
+ functions in js-test-pre.js for waitUntilDone/notifyDone.
+
+ * editing/spelling/spellcheck-sequencenum-expected.txt:
+ * editing/spelling/spellcheck-sequencenum.html:
+ * platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
+
2013-01-14 Levi Weintraub <le...@chromium.org>
Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
Modified: trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt (139635 => 139636)
--- trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt 2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt 2013-01-14 19:53:42 UTC (rev 139636)
@@ -3,10 +3,10 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS successfullyParsed is true
-
-TEST COMPLETE
PASS SpellCheck sequence seems working correctly.
PASS SpellCheck sequence seems working correctly.
PASS SpellCheck sequence seems working correctly.
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html (139635 => 139636)
--- trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html 2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html 2013-01-14 19:53:42 UTC (rev 139636)
@@ -11,7 +11,7 @@
description('For Bug 73511: Internals should have a method to return the max sequence number of spellcheck request.');
if (window.testRunner) {
- testRunner.waitUntilDone();
+ window.jsTestIsAsync = true;
testRunner.setAsynchronousSpellCheckingEnabled(true);
}
@@ -79,7 +79,7 @@
testRoot.style.display = "none";
if (window.testRunner) {
testRunner.setAsynchronousSpellCheckingEnabled(false);
- testRunner.notifyDone();
+ finishJSTest();
}
}
Deleted: trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt (139635 => 139636)
--- trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt 2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt 2013-01-14 19:53:42 UTC (rev 139636)
@@ -1,12 +0,0 @@
-For Bug 73511: Internals should have a method to return the max sequence number of spellcheck request.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS SpellCheck sequence seems working correctly.
-PASS SpellCheck sequence seems working correctly.
-PASS SpellCheck sequence seems working correctly.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
