Title: [139634] trunk/Source/WebCore
- Revision
- 139634
- Author
- yu...@chromium.org
- Date
- 2013-01-14 11:43:42 -0800 (Mon, 14 Jan 2013)
Log Message
[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
https://bugs.webkit.org/show_bug.cgi?id=106807
Reviewed by Pavel Feldman.
Open dedicated worker inspector 600x600 by default and remember its size
after resizing.
* inspector/front-end/Settings.js:
* inspector/front-end/WorkerManager.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139633 => 139634)
--- trunk/Source/WebCore/ChangeLog 2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/ChangeLog 2013-01-14 19:43:42 UTC (rev 139634)
@@ -1,3 +1,16 @@
+2013-01-14 Yury Semikhatsky <yu...@chromium.org>
+
+ [REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
+ https://bugs.webkit.org/show_bug.cgi?id=106807
+
+ Reviewed by Pavel Feldman.
+
+ Open dedicated worker inspector 600x600 by default and remember its size
+ after resizing.
+
+ * inspector/front-end/Settings.js:
+ * inspector/front-end/WorkerManager.js:
+
2013-01-14 Kentaro Hara <hara...@chromium.org>
[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (139633 => 139634)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2013-01-14 19:43:42 UTC (rev 139634)
@@ -115,6 +115,8 @@
this.showMetricsRulers = this.createSetting("showMetricsRulers", false);
this.emulatedCSSMedia = this.createSetting("emulatedCSSMedia", "print");
this.showToolbarIcons = this.createSetting("showToolbarIcons", false);
+ this.workerInspectorWidth = this.createSetting("workerInspectorWidth", 600);
+ this.workerInspectorHeight = this.createSetting("workerInspectorHeight", 600);
// If there are too many breakpoints in a storage, it is likely due to a recent bug that caused
// periodical breakpoints duplication leading to inspector slowness.
Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (139633 => 139634)
--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2013-01-14 19:43:42 UTC (rev 139634)
@@ -171,8 +171,11 @@
url += "&workerPaused=true";
url = "" "");
url += hash;
+ var width = WebInspector.settings.workerInspectorWidth.get();
+ var height = WebInspector.settings.workerInspectorHeight.get();
// Set location=0 just to make sure the front-end will be opened in a separate window, not in new tab.
- var workerInspectorWindow = window.open(url, undefined, "location=0");
+ var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height);
+ workerInspectorWindow.addEventListener("resize", this._onWorkerInspectorResize.bind(this, workerInspectorWindow), false);
this._workerIdToWindow[workerId] = workerInspectorWindow;
workerInspectorWindow.addEventListener("beforeunload", this._workerInspectorClosing.bind(this, workerId), true);
@@ -204,6 +207,13 @@
}
},
+ _onWorkerInspectorResize: function(workerInspectorWindow)
+ {
+ var doc = workerInspectorWindow.document;
+ WebInspector.settings.workerInspectorWidth.set(doc.width);
+ WebInspector.settings.workerInspectorHeight.set(doc.height);
+ },
+
_workerInspectorClosing: function(workerId, event)
{
if (event.target.location.href ="" "about:blank")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
