Title: [139623] trunk
- Revision
- 139623
- Author
- schen...@chromium.org
- Date
- 2013-01-14 10:08:27 -0800 (Mon, 14 Jan 2013)
Log Message
Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
Source/WebKit/chromium:
Unreviewed build fix.
It turns out that the change behind this flag causes crashes and image errors.
* skia_webkit.gyp:
LayoutTests:
Unreviewed expectations clean-up.
Removing the expectations associated with the flag.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139622 => 139623)
--- trunk/LayoutTests/ChangeLog 2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/LayoutTests/ChangeLog 2013-01-14 18:08:27 UTC (rev 139623)
@@ -1,3 +1,13 @@
+2013-01-14 Stephen Chenney <schen...@chromium.org>
+
+ Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
+
+ Unreviewed expectations clean-up.
+
+ Removing the expectations associated with the flag.
+
+ * platform/chromium/TestExpectations:
+
2013-01-14 Tommy Widenflycht <tom...@google.com>
MediaStream API: Update MediaStreamTrack::readyState to match specification
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139622 => 139623)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-14 18:08:27 UTC (rev 139623)
@@ -4267,14 +4267,8 @@
crbug.com/166932 [ Debug ] plugins/embed-attributes-setting.html [ Crash Pass ]
# Broken by Skia flag changes in r139445
-crbug.com/169550 [ Debug ] fast/borders/border-mixed-alpha.html [ Crash ]
-crbug.com/169550 [ Debug ] fast/borders/outline-alpha-block.html [ Crash ]
-crbug.com/169550 [ Debug ] fast/borders/outline-alpha-inline.html [ Crash ]
crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
-crbug.com/169550 [ Release ] fast/borders/border-mixed-alpha.html [ ImageOnlyFailure ]
-crbug.com/169550 [ Release ] fast/borders/outline-alpha-block.html [ ImageOnlyFailure ]
-crbug.com/169550 [ Release ] fast/borders/outline-alpha-inline.html [ ImageOnlyFailure ]
# Transient. Needs rebaseline.
webkit.org/b/103955 fast/repaint/caret-outside-block.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebKit/chromium/ChangeLog (139622 => 139623)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-14 18:08:27 UTC (rev 139623)
@@ -1,3 +1,13 @@
+2013-01-14 Stephen Chenney <schen...@chromium.org>
+
+ Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
+
+ Unreviewed build fix.
+
+ It turns out that the change behind this flag causes crashes and image errors.
+
+ * skia_webkit.gyp:
+
2013-01-14 Kentaro Hara <hara...@chromium.org>
[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (139622 => 139623)
--- trunk/Source/WebKit/chromium/skia_webkit.gyp 2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/Source/WebKit/chromium/skia_webkit.gyp 2013-01-14 18:08:27 UTC (rev 139623)
@@ -43,6 +43,12 @@
# DO NOT remove the define until you are ready to rebaseline, and
# AFTER the flag has been removed from skia.gyp in Chromium.
+ # This flag causes asserts and image errors in border-drawing code
+ # where the borders have alpha. Do not remove this suppression until
+ # those issues have been addressed and the associated tests verified.
+ # See crbug.com/169550
+ 'SK_DISABLE_DASHING_OPTIMIZATION',
+
],
},
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
