Title: [139621] trunk/Source
- Revision
- 139621
- Author
- hara...@chromium.org
- Date
- 2013-01-14 09:40:59 -0800 (Mon, 14 Jan 2013)
Log Message
[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
https://bugs.webkit.org/show_bug.cgi?id=106779
Reviewed by Adam Barth.
This is one of steps to make an Isolate parameter mandatory.
No tests. No change in behavior.
Source/WebCore:
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
Source/WebKit/chromium:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::interruptAndDispatch):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139620 => 139621)
--- trunk/Source/WebCore/ChangeLog 2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebCore/ChangeLog 2013-01-14 17:40:59 UTC (rev 139621)
@@ -1,5 +1,19 @@
2013-01-14 Kentaro Hara <hara...@chromium.org>
+ [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
+ https://bugs.webkit.org/show_bug.cgi?id=106779
+
+ Reviewed by Adam Barth.
+
+ This is one of steps to make an Isolate parameter mandatory.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/ScriptDebugServer.h:
+ (ScriptDebugServer):
+
+2013-01-14 Kentaro Hara <hara...@chromium.org>
+
[V8] Make an Isolate parameter mandatory in wrap()
https://bugs.webkit.org/show_bug.cgi?id=106783
Modified: trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h (139620 => 139621)
--- trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h 2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h 2013-01-14 17:40:59 UTC (rev 139621)
@@ -93,7 +93,7 @@
virtual ~Task() { }
virtual void run() = 0;
};
- static void interruptAndRun(PassOwnPtr<Task>, v8::Isolate* = 0);
+ static void interruptAndRun(PassOwnPtr<Task>, v8::Isolate*);
void runPendingTasks();
bool isPaused();
Modified: trunk/Source/WebKit/chromium/ChangeLog (139620 => 139621)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-14 17:40:59 UTC (rev 139621)
@@ -1,3 +1,17 @@
+2013-01-14 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
+ https://bugs.webkit.org/show_bug.cgi?id=106779
+
+ Reviewed by Adam Barth.
+
+ This is one of steps to make an Isolate parameter mandatory.
+
+ No tests. No change in behavior.
+
+ * src/WebDevToolsAgentImpl.cpp:
+ (WebKit::WebDevToolsAgent::interruptAndDispatch):
+
2013-01-13 Vsevolod Vlasov <vse...@chromium.org>
Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (139620 => 139621)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2013-01-14 17:40:59 UTC (rev 139621)
@@ -733,7 +733,7 @@
// rawDescriptor can't be a PassOwnPtr because interruptAndDispatch is a WebKit API function.
OwnPtr<MessageDescriptor> descriptor = adoptPtr(rawDescriptor);
OwnPtr<DebuggerTask> task = adoptPtr(new DebuggerTask(descriptor.release()));
- PageScriptDebugServer::interruptAndRun(task.release());
+ PageScriptDebugServer::interruptAndRun(task.release(), v8::Isolate::GetCurrent());
}
bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
