Diff
Modified: trunk/Source/WebCore/ChangeLog (139618 => 139619)
--- trunk/Source/WebCore/ChangeLog 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/ChangeLog 2013-01-14 17:30:59 UTC (rev 139619)
@@ -1,3 +1,43 @@
+2013-01-14 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Make an Isolate parameter mandatory in wrap()
+ https://bugs.webkit.org/show_bug.cgi?id=106783
+
+ Reviewed by Adam Barth.
+
+ Now it's safe to make an Isolate parameter in wrap().
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/scripts/test/V8/V8Float64Array.h:
+ (WebCore):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestEventConstructor.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestEventTarget.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestException.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestInterface.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestNode.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestObj.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
+ (WebCore::wrap):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+ (WebCore::wrap):
+
2013-01-14 Tommy Widenflycht <tom...@google.com>
MediaStream API: Update MediaStreamTrack::readyState to match specification
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-01-14 17:30:59 UTC (rev 139619)
@@ -545,12 +545,12 @@
if ($customWrap) {
push(@headerContent, <<END);
-v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* = 0);
+v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);
END
} else {
push(@headerContent, <<END);
-inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -54,7 +54,7 @@
};
-v8::Handle<v8::Object> wrap(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* = 0);
+v8::Handle<v8::Object> wrap(Float64Array* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);
inline v8::Handle<v8::Value> toV8(Float64Array* impl, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)
{
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -54,7 +54,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestActiveDOMObject* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -53,7 +53,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestCustomNamedGetter* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -54,7 +54,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestEventConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -55,7 +55,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestEventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -52,7 +52,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestException* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -57,7 +57,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -52,7 +52,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestMediaQueryListListener* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -59,7 +59,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestNamedConstructor* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -53,7 +53,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestNode* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -58,7 +58,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestObj* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -57,7 +57,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestOverloadedConstructors* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h (139618 => 139619)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h 2013-01-14 17:30:59 UTC (rev 139619)
@@ -55,7 +55,7 @@
};
-inline v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate = 0)
+inline v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
