Title: [139605] trunk/LayoutTests
- Revision
- 139605
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-14 04:05:58 -0800 (Mon, 14 Jan 2013)
Log Message
Web Inspector: InspectorTest.createTestEditor should not set any text in editor
https://bugs.webkit.org/show_bug.cgi?id=106772
Patch by Andrey Lushnikov <lushni...@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.
Add InspectorTest.fillEditorWithText helper method and remove this
functionality from InspectorTest.createTestEditor method.
* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
* inspector/editor/text-editor-remove-chunks-from-dom.html:
* inspector/editor/text-editor-selection.html:
* inspector/editor/text-editor-type-over-decoration.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139604 => 139605)
--- trunk/LayoutTests/ChangeLog 2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/ChangeLog 2013-01-14 12:05:58 UTC (rev 139605)
@@ -1,3 +1,20 @@
+2013-01-14 Andrey Lushnikov <lushni...@chromium.org>
+
+ Web Inspector: InspectorTest.createTestEditor should not set any text in editor
+ https://bugs.webkit.org/show_bug.cgi?id=106772
+
+ Reviewed by Pavel Feldman.
+
+ Add InspectorTest.fillEditorWithText helper method and remove this
+ functionality from InspectorTest.createTestEditor method.
+
+ * inspector/editor/editor-test.js:
+ (initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
+ (initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
+ * inspector/editor/text-editor-remove-chunks-from-dom.html:
+ * inspector/editor/text-editor-selection.html:
+ * inspector/editor/text-editor-type-over-decoration.html:
+
2013-01-14 Csaba Osztrogonác <o...@webkit.org>
[Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.
Modified: trunk/LayoutTests/inspector/editor/editor-test.js (139604 => 139605)
--- trunk/LayoutTests/inspector/editor/editor-test.js 2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/editor-test.js 2013-01-14 12:05:58 UTC (rev 139605)
@@ -1,19 +1,23 @@
function initialize_EditorTests()
{
-InspectorTest.createTestEditor = function(lineCount, clientHeight, chunkSize)
+InspectorTest.createTestEditor = function(clientHeight, chunkSize)
{
WebInspector.debugDefaultTextEditor = true;
var textEditor = new WebInspector.DefaultTextEditor("", new WebInspector.TextEditorDelegate());
textEditor.overrideViewportForTest(0, clientHeight || 100, chunkSize || 10);
textEditor.show(WebInspector.inspectorView.element);
+ return textEditor;
+};
+
+InspectorTest.fillEditorWithText = function(textEditor, lineCount)
+{
var textModel = textEditor._textModel;
var lines = [];
for (var i = 0; i < lineCount; ++i)
lines.push(i);
textModel.setText(lines.join("\n"));
- return textEditor;
-};
+}
InspectorTest.dumpEditorChunks = function(textEditor)
{
Modified: trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html (139604 => 139605)
--- trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html 2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html 2013-01-14 12:05:58 UTC (rev 139605)
@@ -9,7 +9,8 @@
InspectorTest.runTestSuite([
function testDamageLastChunk(next)
{
- var textEditor = InspectorTest.createTestEditor(5);
+ var textEditor = InspectorTest.createTestEditor();
+ InspectorTest.fillEditorWithText(textEditor, 5);
textEditor.setText(textEditor.text() + "\n");
InspectorTest.addResult("\nBefore editing");
InspectorTest.dumpEditorModel(textEditor);
Modified: trunk/LayoutTests/inspector/editor/text-editor-selection.html (139604 => 139605)
--- trunk/LayoutTests/inspector/editor/text-editor-selection.html 2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/text-editor-selection.html 2013-01-14 12:05:58 UTC (rev 139605)
@@ -6,7 +6,8 @@
function test()
{
- var textEditor = InspectorTest.createTestEditor(34);
+ var textEditor = InspectorTest.createTestEditor();
+ InspectorTest.fillEditorWithText(textEditor, 34);
InspectorTest.dumpEditorChunks(textEditor);
InspectorTest.runTestSuite([
Modified: trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html (139604 => 139605)
--- trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html 2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html 2013-01-14 12:05:58 UTC (rev 139605)
@@ -6,7 +6,8 @@
function test()
{
- var textEditor = InspectorTest.createTestEditor(10);
+ var textEditor = InspectorTest.createTestEditor();
+ InspectorTest.fillEditorWithText(textEditor, 10);
var textModel = textEditor._textModel;
InspectorTest.dumpEditorChunks(textEditor);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
