Title: [139332] trunk/LayoutTests
- Revision
- 139332
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-10 10:25:39 -0800 (Thu, 10 Jan 2013)
Log Message
Web Inspector: Refactor InspectorTest to create output interface
https://bugs.webkit.org/show_bug.cgi?id=106231
Patch by John J. Barton <johnjbar...@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.
Refactor InspectorTest to extract InspectorTest.Output, the API
used between InspectorTest and the test output reciever (the
test-script page by default).
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.Output.testComplete):
(initialize_InspectorTest.InspectorTest.Output.addResult):
(initialize_InspectorTest.InspectorTest.Output.clearResults):
(initialize_InspectorTest.InspectorTest.completeTest):
(initialize_InspectorTest.InspectorTest.addResult):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139331 => 139332)
--- trunk/LayoutTests/ChangeLog 2013-01-10 18:25:07 UTC (rev 139331)
+++ trunk/LayoutTests/ChangeLog 2013-01-10 18:25:39 UTC (rev 139332)
@@ -1,3 +1,21 @@
+2013-01-10 John J. Barton <johnjbar...@chromium.org>
+
+ Web Inspector: Refactor InspectorTest to create output interface
+ https://bugs.webkit.org/show_bug.cgi?id=106231
+
+ Reviewed by Pavel Feldman.
+
+ Refactor InspectorTest to extract InspectorTest.Output, the API
+ used between InspectorTest and the test output reciever (the
+ test-script page by default).
+
+ * http/tests/inspector/inspector-test.js:
+ (initialize_InspectorTest.InspectorTest.Output.testComplete):
+ (initialize_InspectorTest.InspectorTest.Output.addResult):
+ (initialize_InspectorTest.InspectorTest.Output.clearResults):
+ (initialize_InspectorTest.InspectorTest.completeTest):
+ (initialize_InspectorTest.InspectorTest.addResult):
+
2013-01-10 Max Vujovic <mvujo...@adobe.com>
[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the filters outsets (ie. blur and drop-shadow)
Modified: trunk/LayoutTests/http/tests/inspector/inspector-test.js (139331 => 139332)
--- trunk/LayoutTests/http/tests/inspector/inspector-test.js 2013-01-10 18:25:07 UTC (rev 139331)
+++ trunk/LayoutTests/http/tests/inspector/inspector-test.js 2013-01-10 18:25:39 UTC (rev 139332)
@@ -12,6 +12,23 @@
console.error = consoleOutputHook.bind(InspectorTest, "error");
console.info = consoleOutputHook.bind(InspectorTest, "info");
+InspectorTest.Output = { // override in window.initialize_yourName
+ testComplete: function()
+ {
+ RuntimeAgent.evaluate("didEvaluateForTestInFrontend(" + InspectorTest.completeTestCallId + ", \"\")", "test");
+ },
+
+ addResult: function(text)
+ {
+ InspectorTest.evaluateInPage("output(unescape('" + escape(text) + "'))");
+ },
+
+ clearResults: function()
+ {
+ InspectorTest.evaluateInPage("clearOutput()");
+ }
+};
+
InspectorTest.completeTest = function()
{
function testDispatchQueueIsEmpty() {
@@ -20,7 +37,7 @@
setTimeout(testDispatchQueueIsEmpty, 10);
return;
}
- RuntimeAgent.evaluate("didEvaluateForTestInFrontend(" + InspectorTest.completeTestCallId + ", \"\")", "test");
+ InspectorTest.Output.testComplete();
}
testDispatchQueueIsEmpty();
}
@@ -73,23 +90,13 @@
{
results.push(text);
if (resultsSynchronized)
- addResultToPage(text);
+ InspectorTest.Output.addResult(text);
else {
- clearResults();
+ InspectorTest.Output.clearResults();
for (var i = 0; i < results.length; ++i)
- addResultToPage(results[i]);
+ InspectorTest.Output.addResult(results[i]);
resultsSynchronized = true;
}
-
- function clearResults()
- {
- InspectorTest.evaluateInPage("clearOutput()");
- }
-
- function addResultToPage(text)
- {
- InspectorTest.evaluateInPage("output(unescape('" + escape(text) + "'))");
- }
}
InspectorTest.addResults = function(textArray)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
