Title: [139203] trunk
Revision
139203
Author
o...@chromium.org
Date
2013-01-09 10:10:34 -0800 (Wed, 09 Jan 2013)

Log Message

Source/WebCore: marquee special-case in RenderBlock is not needed
https://bugs.webkit.org/show_bug.cgi?id=106396

Reviewed by Simon Fraser.

This was added in http://trac.webkit.org/changeset/105772. The layout test
in that patch (which is disabled) works and the original site that was broken
also still works.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):

LayoutTests: Implement CSS computed style value for transition shorthand
https://bugs.webkit.org/show_bug.cgi?id=105035

Patch by Alexis Menard <ale...@webkit.org> on 2013-01-09
Reviewed by Dean Jackson.

Uncomment existing tests to cover the new feature.

* transitions/transitions-parsing-expected.txt:
* transitions/transitions-parsing.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (139202 => 139203)


--- trunk/LayoutTests/ChangeLog	2013-01-09 18:07:37 UTC (rev 139202)
+++ trunk/LayoutTests/ChangeLog	2013-01-09 18:10:34 UTC (rev 139203)
@@ -1,3 +1,15 @@
+2013-01-09  Alexis Menard  <ale...@webkit.org>
+
+        Implement CSS computed style value for transition shorthand
+        https://bugs.webkit.org/show_bug.cgi?id=105035
+
+        Reviewed by Dean Jackson.
+
+        Uncomment existing tests to cover the new feature.
+
+        * transitions/transitions-parsing-expected.txt:
+        * transitions/transitions-parsing.html:
+
 2013-01-09  Tony Chang  <t...@chromium.org>
 
         Automatically generate Settings::unifiedTextCheckerEnabled

Modified: trunk/Source/WebCore/ChangeLog (139202 => 139203)


--- trunk/Source/WebCore/ChangeLog	2013-01-09 18:07:37 UTC (rev 139202)
+++ trunk/Source/WebCore/ChangeLog	2013-01-09 18:10:34 UTC (rev 139203)
@@ -1,3 +1,38 @@
+2013-01-09  Ojan Vafai  <o...@chromium.org>
+
+        marquee special-case in RenderBlock is not needed
+        https://bugs.webkit.org/show_bug.cgi?id=106396
+
+        Reviewed by Simon Fraser.
+
+        This was added in http://trac.webkit.org/changeset/105772. The layout test
+        in that patch (which is disabled) works and the original site that was broken
+        also still works.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::computePreferredLogicalWidths):
+
+2013-01-09  Alexis Menard  <ale...@webkit.org>
+
+        Implement CSS computed style value for transition shorthand
+        https://bugs.webkit.org/show_bug.cgi?id=105035
+
+        Reviewed by Dean Jackson.
+
+        Implement support for query the transition and webkit-transition
+        shorthand from the computed style.
+
+        Test: transitions/transitions-parsing.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::createTransitionPropertyValue): Factor the code to create the
+        correct value into a function to reuse it for the shorthand.
+        (WebCore::getTransitionPropertyValue):
+        (WebCore::createTimingFunctionValue): Little refactor, the intermediate
+        local variables are not needed.
+        (WebCore::getTimingFunctionValue):
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
 2013-01-09  Tony Chang  <t...@chromium.org>
 
         Automatically generate Settings::unifiedTextCheckerEnabled

Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (139202 => 139203)


--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-01-09 18:07:37 UTC (rev 139202)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-01-09 18:10:34 UTC (rev 139203)
@@ -5583,7 +5583,7 @@
 
     RenderStyle* styleToUse = style();
     if (!isTableCell() && styleToUse->logicalWidth().isFixed() && styleToUse->logicalWidth().value() >= 0 
-       && style()->marqueeBehavior() != MALTERNATE && !(isDeprecatedFlexItem() && !styleToUse->logicalWidth().intValue()))
+        && !(isDeprecatedFlexItem() && !styleToUse->logicalWidth().intValue()))
         m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = adjustContentBoxLogicalWidthForBoxSizing(styleToUse->logicalWidth().value());
     else {
         m_minPreferredLogicalWidth = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to