Title: [139091] trunk/Source/WebCore
- Revision
- 139091
- Author
- cfleiz...@apple.com
- Date
- 2013-01-08 11:52:53 -0800 (Tue, 08 Jan 2013)
Log Message
AX: native popup buttons should not use textUnderElement for their title
https://bugs.webkit.org/show_bug.cgi?id=106349
Reviewed by Ryosuke Niwa.
Native popup buttons (<select> elements) were calculating its title based on the text
under the element. When Bug 103794 introduced a more complete way of getting render text,
it causes popup buttons to start returning a title.
The fix is that we should not be calculating a title for a native popup button from its children.
Existing tests cover this functionality. This will fix a failing test.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139090 => 139091)
--- trunk/Source/WebCore/ChangeLog 2013-01-08 19:49:34 UTC (rev 139090)
+++ trunk/Source/WebCore/ChangeLog 2013-01-08 19:52:53 UTC (rev 139091)
@@ -1,3 +1,20 @@
+2013-01-08 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: native popup buttons should not use textUnderElement for their title
+ https://bugs.webkit.org/show_bug.cgi?id=106349
+
+ Reviewed by Ryosuke Niwa.
+
+ Native popup buttons (<select> elements) were calculating its title based on the text
+ under the element. When Bug 103794 introduced a more complete way of getting render text,
+ it causes popup buttons to start returning a title.
+ The fix is that we should not be calculating a title for a native popup button from its children.
+
+ Existing tests cover this functionality. This will fix a failing test.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::visibleText):
+
2013-01-08 Ojan Vafai <o...@chromium.org>
text controls are sized too small when a percentage height is set
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (139090 => 139091)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-01-08 19:49:34 UTC (rev 139090)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-01-08 19:52:53 UTC (rev 139091)
@@ -1192,6 +1192,9 @@
switch (roleValue()) {
case PopUpButtonRole:
+ // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
+ if (node->hasTagName(selectTag))
+ break;
case ButtonRole:
case ToggleButtonRole:
case CheckBoxRole:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
