Title: [139017] trunk/Source/WebKit/chromium
- Revision
- 139017
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-07 17:08:12 -0800 (Mon, 07 Jan 2013)
Log Message
Don't use double tap zoom if minimum and maximum page scale is the same
https://bugs.webkit.org/show_bug.cgi?id=106272
Patch by Yusuf Ozuysal <yus...@google.com> on 2013-01-07
Reviewed by James Robinson.
We should only try to computed relevant scale and scrollOffset and start the animation
if the page is zoomable. This now creates an undesired animation for mobile pages which
are not zoomable.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (139016 => 139017)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-08 01:00:44 UTC (rev 139016)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-08 01:08:12 UTC (rev 139017)
@@ -1,3 +1,17 @@
+2013-01-07 Yusuf Ozuysal <yus...@google.com>
+
+ Don't use double tap zoom if minimum and maximum page scale is the same
+ https://bugs.webkit.org/show_bug.cgi?id=106272
+
+ Reviewed by James Robinson.
+
+ We should only try to computed relevant scale and scrollOffset and start the animation
+ if the page is zoomable. This now creates an undesired animation for mobile pages which
+ are not zoomable.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::handleGestureEvent):
+
2013-01-07 Tony Chang <t...@chromium.org>
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (139016 => 139017)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-08 01:00:44 UTC (rev 139016)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-08 01:08:12 UTC (rev 139017)
@@ -775,7 +775,7 @@
break;
}
case WebInputEvent::GestureDoubleTap:
- if (m_webSettings->doubleTapToZoomEnabled()) {
+ if (m_webSettings->doubleTapToZoomEnabled() && m_minimumPageScaleFactor != m_maximumPageScaleFactor) {
m_client->cancelScheduledContentIntents();
animateZoomAroundPoint(WebPoint(event.x, event.y), DoubleTap);
eventSwallowed = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
