Title: [138840] trunk
Revision
138840
Author
t...@chromium.org
Date
2013-01-04 12:51:10 -0800 (Fri, 04 Jan 2013)

Log Message

Remove some autogenerated settings from InternalSettings.idl
https://bugs.webkit.org/show_bug.cgi?id=106114

Reviewed by Ojan Vafai.

Source/WebCore:

Remove 6 methods that are now autogenerated.
setAcceleratedFiltersEnabled was never called.
AcceleratedCompositingForOverflowScrollEnabled was never backed up/restored.
setEnableCompositingForFixedPosition and setEnableCompositingForScrollableFrames
are renamed to match the name in Settings.in.

No new tests, there should be no change in behavior. This is covered by
existing tests in compositing and platform/chromium/compositing.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove code.
(WebCore::InternalSettings::Backup::restoreTo): Remove code.
* testing/InternalSettings.h:
(Backup): Remove member variables.
(InternalSettings):
* testing/InternalSettings.idl: Remove methods that are no longer used.

LayoutTests:

Rename setters to match the name in Settings.in
setEnableCompositingForFixedPosition -> setAcceleratedCompositingForFixedPositionEnabled
setEnableCompositingForScrollableFrames -> setAcceleratedCompositingForScrollableFramesEnabled

* compositing/absolute-inside-out-of-view-fixed.html:
* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale-scroll.html:
* compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-composited-switch.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled.html:
* compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
* compositing/layer-creation/fixed-position-out-of-view.html:
* compositing/overflow/automatically-opt-into-composited-scrolling.html:
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (138839 => 138840)


--- trunk/LayoutTests/ChangeLog	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/ChangeLog	2013-01-04 20:51:10 UTC (rev 138840)
@@ -1,3 +1,38 @@
+2013-01-04  Tony Chang  <t...@chromium.org>
+
+        Remove some autogenerated settings from InternalSettings.idl
+        https://bugs.webkit.org/show_bug.cgi?id=106114
+
+        Reviewed by Ojan Vafai.
+
+        Rename setters to match the name in Settings.in
+        setEnableCompositingForFixedPosition -> setAcceleratedCompositingForFixedPositionEnabled
+        setEnableCompositingForScrollableFrames -> setAcceleratedCompositingForScrollableFramesEnabled
+
+        * compositing/absolute-inside-out-of-view-fixed.html:
+        * compositing/geometry/fixed-position-composited-page-scale-down.html:
+        * compositing/geometry/fixed-position-composited-page-scale-scroll.html:
+        * compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
+        * compositing/geometry/fixed-position-composited-page-scale.html:
+        * compositing/geometry/fixed-position-composited-switch.html:
+        * compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
+        * compositing/geometry/fixed-position-iframe-composited-page-scale.html:
+        * compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
+        * compositing/geometry/fixed-position-transform-composited-page-scale.html:
+        * compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
+        * compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
+        * compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
+        * compositing/layer-creation/fixed-position-out-of-view-scaled.html:
+        * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
+        * compositing/layer-creation/fixed-position-out-of-view.html:
+        * compositing/overflow/automatically-opt-into-composited-scrolling.html:
+        * platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
+        * platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
+        * platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
+        * platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
+        * platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
+        * platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
+
 2013-01-04  Ojan Vafai  <o...@chromium.org>
 
         Vertical writing mode can overflow fixed size grandparent container

Modified: trunk/LayoutTests/compositing/absolute-inside-out-of-view-fixed.html (138839 => 138840)


--- trunk/LayoutTests/compositing/absolute-inside-out-of-view-fixed.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/absolute-inside-out-of-view-fixed.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -30,7 +30,7 @@
         testRunner.waitUntilDone();
         testRunner.dumpAsText();
         if (window.internals) {
-            window.internals.settings.setEnableCompositingForFixedPosition(true);
+            window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
             window.internals.settings.setFixedPositionCreatesStackingContext(true);
         }
       }

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(0.5, 0, 0);
   }
   if (window.testRunner)

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -15,7 +15,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(2, 0, 0);
   }
   function test() {

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -25,7 +25,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.settings.setFixedPositionCreatesStackingContext(true);
     window.internals.setPageScaleFactor(0.5, 0, 0);
   }

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(2, 0, 0);
   }
   if (window.testRunner)

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -19,7 +19,7 @@
   </style>
   <script type="text/_javascript_" charset="utf-8">
     if (window.internals) 
-      window.internals.settings.setEnableCompositingForFixedPosition(true);
+      window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
 
     function doTest()
     {

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(0.5, 0, 0);
   }
   function test() {

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(2, 0, 0);
   }
   function test() {

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -16,7 +16,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(0.5, 0, 0);
   }
   if (window.testRunner)

Modified: trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html (138839 => 138840)


--- trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -16,7 +16,7 @@
 </style>
 <script>
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.setPageScaleFactor(2, 0, 0);
   }
   if (window.testRunner)

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -7,7 +7,7 @@
     testRunner.waitUntilDone();
   }
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.settings.setFixedPositionCreatesStackingContext(true);
 
     addEventListener("load", function() {

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -7,7 +7,7 @@
     testRunner.waitUntilDone();
   }
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.settings.setFixedPositionCreatesStackingContext(true);
 
     addEventListener("load", function() {

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
     testRunner.waitUntilDone();
   }
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.settings.setFixedPositionCreatesStackingContext(true);
 
     addEventListener("load", function() {

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -14,7 +14,7 @@
     testRunner.waitUntilDone();
   }
   if (window.internals) {
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
     window.internals.settings.setFixedPositionCreatesStackingContext(true);
 
     addEventListener("load", function() {

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -13,7 +13,7 @@
 
 <script type="text/_javascript_">
   if (window.internals)
-    window.internals.settings.setEnableCompositingForFixedPosition(true);
+    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
 
   if (window.testRunner) {
     testRunner.dumpAsText();

Modified: trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view.html (138839 => 138840)


--- trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -12,7 +12,7 @@
 
   <script type="text/_javascript_">
     if (window.internals)
-      window.internals.settings.setEnableCompositingForFixedPosition(true);
+      window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
 
     if (window.testRunner) {
       testRunner.dumpAsText();

Modified: trunk/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html (138839 => 138840)


--- trunk/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -53,7 +53,7 @@
       testRunner.dumpAsText();
 
     if (window.internals)
-      window.internals.settings.setEnableCompositingForOverflowScroll(true);
+      window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled(true);
 
     function write(str)
     {

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -3,7 +3,7 @@
     <script>
       if (window.internals) {
         window.internals.settings.setForceCompositingMode(true);
-        window.internals.settings.setEnableCompositingForScrollableFrames(true);
+        window.internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
       }
       function doTest() {
         if (window.testRunner) {

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -17,7 +17,7 @@
     window.addEventListener("load", doTest, false);
     if (window.internals) {
       internals.settings.setForceCompositingMode(true);
-      internals.settings.setEnableCompositingForScrollableFrames(true);
+      internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
     }
   </script>
 </head>

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -9,7 +9,7 @@
   <script>
     if (window.internals) {
       internals.settings.setForceCompositingMode(true);
-      internals.settings.setEnableCompositingForScrollableFrames(true);
+      internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
     }
     function doTest()
     {

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -9,7 +9,7 @@
   <script>
     if (window.internals) {
       internals.settings.setForceCompositingMode(true);
-      internals.settings.setEnableCompositingForScrollableFrames(true);
+      internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
     }
     function doTest()
     {

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -9,7 +9,7 @@
   <script>
     if (window.internals) {
       internals.settings.setForceCompositingMode(true);
-      internals.settings.setEnableCompositingForScrollableFrames(true);
+      internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
     }
     function doTest()
     {

Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html (138839 => 138840)


--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html	2013-01-04 20:51:10 UTC (rev 138840)
@@ -9,7 +9,7 @@
   <script>
     if (window.internals) {
       internals.settings.setForceCompositingMode(true);
-      internals.settings.setEnableCompositingForScrollableFrames(true);
+      internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
     }
     function doTest()
     {

Modified: trunk/Source/WebCore/ChangeLog (138839 => 138840)


--- trunk/Source/WebCore/ChangeLog	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/Source/WebCore/ChangeLog	2013-01-04 20:51:10 UTC (rev 138840)
@@ -1,3 +1,27 @@
+2013-01-04  Tony Chang  <t...@chromium.org>
+
+        Remove some autogenerated settings from InternalSettings.idl
+        https://bugs.webkit.org/show_bug.cgi?id=106114
+
+        Reviewed by Ojan Vafai.
+
+        Remove 6 methods that are now autogenerated.
+        setAcceleratedFiltersEnabled was never called.
+        AcceleratedCompositingForOverflowScrollEnabled was never backed up/restored.
+        setEnableCompositingForFixedPosition and setEnableCompositingForScrollableFrames
+        are renamed to match the name in Settings.in.
+
+        No new tests, there should be no change in behavior. This is covered by
+        existing tests in compositing and platform/chromium/compositing.
+
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::Backup::Backup): Remove code.
+        (WebCore::InternalSettings::Backup::restoreTo): Remove code.
+        * testing/InternalSettings.h:
+        (Backup): Remove member variables.
+        (InternalSettings):
+        * testing/InternalSettings.idl: Remove methods that are no longer used.
+
 2013-01-04  Ojan Vafai  <o...@chromium.org>
 
         Vertical writing mode can overflow fixed size grandparent container

Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (138839 => 138840)


--- trunk/Source/WebCore/testing/InternalSettings.cpp	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp	2013-01-04 20:51:10 UTC (rev 138840)
@@ -90,10 +90,6 @@
 #if ENABLE(DIALOG_ELEMENT)
     , m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnabled())
 #endif
-    , m_originalForceCompositingMode(settings->forceCompositingMode())
-    , m_originalCompositingForFixedPositionEnabled(settings->acceleratedCompositingForFixedPositionEnabled())
-    , m_originalCompositingForScrollableFramesEnabled(settings->acceleratedCompositingForScrollableFramesEnabled())
-    , m_originalAcceleratedDrawingEnabled(settings->acceleratedDrawingEnabled())
     , m_originalCanvasUsesAcceleratedDrawing(settings->canvasUsesAcceleratedDrawing())
     , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
     , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
@@ -135,10 +131,6 @@
 #if ENABLE(DIALOG_ELEMENT)
     RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabled);
 #endif
-    settings->setForceCompositingMode(m_originalForceCompositingMode);
-    settings->setAcceleratedCompositingForFixedPositionEnabled(m_originalCompositingForFixedPositionEnabled);
-    settings->setAcceleratedCompositingForScrollableFramesEnabled(m_originalCompositingForScrollableFramesEnabled);
-    settings->setAcceleratedDrawingEnabled(m_originalAcceleratedDrawingEnabled);
     settings->setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing);
     settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
     RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
@@ -204,42 +196,6 @@
     return page()->settings();
 }
 
-void InternalSettings::setForceCompositingMode(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setForceCompositingMode(enabled);
-}
-
-void InternalSettings::setAcceleratedFiltersEnabled(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setAcceleratedFiltersEnabled(enabled);
-}
-
-void InternalSettings::setEnableCompositingForFixedPosition(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setAcceleratedCompositingForFixedPositionEnabled(enabled);
-}
-
-void InternalSettings::setEnableCompositingForScrollableFrames(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setAcceleratedCompositingForScrollableFramesEnabled(enabled);
-}
-
-void InternalSettings::setEnableCompositingForOverflowScroll(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setAcceleratedCompositingForOverflowScrollEnabled(enabled);
-}
-
-void InternalSettings::setAcceleratedDrawingEnabled(bool enabled, ExceptionCode& ec)
-{
-    InternalSettingsGuardForSettings();
-    settings()->setAcceleratedDrawingEnabled(enabled);
-}
-
 void InternalSettings::setMockScrollbarsEnabled(bool enabled, ExceptionCode& ec)
 {
     InternalSettingsGuardForSettings();

Modified: trunk/Source/WebCore/testing/InternalSettings.h (138839 => 138840)


--- trunk/Source/WebCore/testing/InternalSettings.h	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/Source/WebCore/testing/InternalSettings.h	2013-01-04 20:51:10 UTC (rev 138840)
@@ -76,10 +76,6 @@
 #if ENABLE(DIALOG_ELEMENT)
         bool m_originalDialogElementEnabled;
 #endif
-        bool m_originalForceCompositingMode;
-        bool m_originalCompositingForFixedPositionEnabled;
-        bool m_originalCompositingForScrollableFramesEnabled;
-        bool m_originalAcceleratedDrawingEnabled;
         bool m_originalCanvasUsesAcceleratedDrawing;
         bool m_originalMockScrollbarsEnabled;
         bool m_originalUsesOverlayScrollbars;
@@ -102,12 +98,6 @@
     virtual ~InternalSettings();
     void resetToConsistentState();
 
-    void setForceCompositingMode(bool enabled, ExceptionCode&);
-    void setEnableCompositingForFixedPosition(bool enabled, ExceptionCode&);
-    void setEnableCompositingForScrollableFrames(bool enabled, ExceptionCode&);
-    void setEnableCompositingForOverflowScroll(bool enabled, ExceptionCode&);
-    void setAcceleratedDrawingEnabled(bool enabled, ExceptionCode&);
-    void setAcceleratedFiltersEnabled(bool enabled, ExceptionCode&);
     void setMockScrollbarsEnabled(bool enabled, ExceptionCode&);
     void setUsesOverlayScrollbars(bool enabled, ExceptionCode&);
     void setFixedElementsLayoutRelativeToFrame(bool, ExceptionCode&);

Modified: trunk/Source/WebCore/testing/InternalSettings.idl (138839 => 138840)


--- trunk/Source/WebCore/testing/InternalSettings.idl	2013-01-04 20:51:08 UTC (rev 138839)
+++ trunk/Source/WebCore/testing/InternalSettings.idl	2013-01-04 20:51:10 UTC (rev 138840)
@@ -27,12 +27,6 @@
     OmitConstructor,
     JSGenerateToJSObject
 ] interface InternalSettings : InternalSettingsGenerated {
-    void setForceCompositingMode(in boolean enabled) raises(DOMException);
-    void setEnableCompositingForFixedPosition(in boolean enabled) raises(DOMException);
-    void setEnableCompositingForScrollableFrames(in boolean enabled) raises(DOMException);
-    void setEnableCompositingForOverflowScroll(in boolean enabled) raises(DOMException);
-    void setAcceleratedDrawingEnabled(in boolean enabled) raises(DOMException);
-    void setAcceleratedFiltersEnabled(in boolean enabled) raises(DOMException);
     void setMockScrollbarsEnabled(in boolean enabled) raises(DOMException);
     void setFixedElementsLayoutRelativeToFrame(in boolean enabled) raises(DOMException);
     void setUnifiedTextCheckingEnabled(in boolean enabled) raises (DOMException);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to