Title: [138831] trunk/Source/Platform
Revision
138831
Author
commit-qu...@webkit.org
Date
2013-01-04 12:25:40 -0800 (Fri, 04 Jan 2013)

Log Message

[chromium] Remove static create functions from types WebCompositorSupport can construct
https://bugs.webkit.org/show_bug.cgi?id=99877

Patch by James Robinson <jam...@chromium.org> on 2013-01-04
Reviewed by Adrienne Walker.

* chromium/public/WebAnimation.h:
* chromium/public/WebContentLayer.h:
* chromium/public/WebExternalTextureLayer.h:
* chromium/public/WebFloatAnimationCurve.h:
* chromium/public/WebIOSurfaceLayer.h:
* chromium/public/WebImageLayer.h:
* chromium/public/WebLayer.h:
* chromium/public/WebLayerTreeView.h:
* chromium/public/WebScrollbarLayer.h:
* chromium/public/WebSolidColorLayer.h:
* chromium/public/WebTransformAnimationCurve.h:
* chromium/public/WebVideoLayer.h:

Modified Paths

Diff

Modified: trunk/Source/Platform/ChangeLog (138830 => 138831)


--- trunk/Source/Platform/ChangeLog	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/ChangeLog	2013-01-04 20:25:40 UTC (rev 138831)
@@ -1,5 +1,25 @@
 2013-01-04  James Robinson  <jam...@chromium.org>
 
+        [chromium] Remove static create functions from types WebCompositorSupport can construct
+        https://bugs.webkit.org/show_bug.cgi?id=99877
+
+        Reviewed by Adrienne Walker.
+
+        * chromium/public/WebAnimation.h:
+        * chromium/public/WebContentLayer.h:
+        * chromium/public/WebExternalTextureLayer.h:
+        * chromium/public/WebFloatAnimationCurve.h:
+        * chromium/public/WebIOSurfaceLayer.h:
+        * chromium/public/WebImageLayer.h:
+        * chromium/public/WebLayer.h:
+        * chromium/public/WebLayerTreeView.h:
+        * chromium/public/WebScrollbarLayer.h:
+        * chromium/public/WebSolidColorLayer.h:
+        * chromium/public/WebTransformAnimationCurve.h:
+        * chromium/public/WebVideoLayer.h:
+
+2013-01-04  James Robinson  <jam...@chromium.org>
+
         [chromium] WebTransformationMatrix shouldn't alias memory for TransformationMatrix
         https://bugs.webkit.org/show_bug.cgi?id=106025
 

Modified: trunk/Source/Platform/chromium/public/WebAnimation.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebAnimation.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebAnimation.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -49,11 +49,6 @@
         TargetPropertyOpacity
     };
 
-    // The caller takes ownership of the returned value.
-    // Pass a non-zero value for animationId specify an id to use for this animation, otherwise one will
-    // be generated for you.
-    WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve&, TargetProperty, int animationId = 0);
-
     virtual ~WebAnimation() { }
 
     // An id is effectively the animation's name, and it is not unique.

Modified: trunk/Source/Platform/chromium/public/WebContentLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebContentLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebContentLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -34,9 +34,6 @@
 
 class WebContentLayer {
 public:
-    // The client must outlive the WebContentLayer.
-    WEBKIT_EXPORT static WebContentLayer* create(WebContentLayerClient*);
-
     virtual ~WebContentLayer() { }
 
     // The WebContentLayer has ownership of this wrapper.

Modified: trunk/Source/Platform/chromium/public/WebExternalTextureLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebExternalTextureLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebExternalTextureLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -42,13 +42,6 @@
 // the WebLayerTreeView is destroyed.
 class WebExternalTextureLayer {
 public:
-    // The owner of this layer may optionally provide a client. This client will
-    // be called whenever the compositor wishes to produce a new frame and can
-    // provide a new front buffer texture ID. This is useful if the client wants to
-    // implement a double-buffering scheme that is synchronized with the compositor, for instance.
-    // The client must outlive the WebExternalTextureLayer.
-    WEBKIT_EXPORT static WebExternalTextureLayer* create(WebExternalTextureLayerClient* = 0);
-
     virtual ~WebExternalTextureLayer() { }
 
     virtual WebLayer* layer() = 0;

Modified: trunk/Source/Platform/chromium/public/WebFloatAnimationCurve.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebFloatAnimationCurve.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebFloatAnimationCurve.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -35,8 +35,6 @@
 // A keyframed float animation curve.
 class WebFloatAnimationCurve : public WebAnimationCurve {
 public:
-    WEBKIT_EXPORT static WebFloatAnimationCurve* create();
-
     virtual ~WebFloatAnimationCurve() { }
 
     // Adds the keyframe with the default timing function (ease).

Modified: trunk/Source/Platform/chromium/public/WebIOSurfaceLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebIOSurfaceLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebIOSurfaceLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -35,8 +35,6 @@
 // This class represents a layer that renders an externally managed IOSurface.
 class WebIOSurfaceLayer {
 public:
-    WEBKIT_EXPORT static WebIOSurfaceLayer* create();
-
     virtual ~WebIOSurfaceLayer() { }
 
     virtual WebLayer* layer() = 0;

Modified: trunk/Source/Platform/chromium/public/WebImageLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebImageLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebImageLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -34,8 +34,6 @@
 
 class WebImageLayer {
 public:
-    WEBKIT_EXPORT static WebImageLayer* create();
-
     virtual ~WebImageLayer() { }
 
     virtual WebLayer* layer() = 0;

Modified: trunk/Source/Platform/chromium/public/WebLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -51,8 +51,6 @@
 
 class WebLayer {
 public:
-    WEBKIT_EXPORT static WebLayer* create();
-
     virtual ~WebLayer() { }
 
     // Returns a positive ID that will be unique across all WebLayers allocated in this process.

Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -78,10 +78,6 @@
         WebSize maxUntiledLayerSize;
     };
 
-    // Attempts to initialize this WebLayerTreeView with the given client, root layer, and settings.
-    // If initialization fails, this will return nil.
-    WEBKIT_EXPORT static WebLayerTreeView* create(WebLayerTreeViewClient*, const WebLayer& root, const Settings&);
-
     virtual ~WebLayerTreeView() { }
 
     // Initialization and lifecycle --------------------------------------

Modified: trunk/Source/Platform/chromium/public/WebScrollbarLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebScrollbarLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebScrollbarLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -38,9 +38,6 @@
 
 class WebScrollbarLayer {
 public:
-    // This takes ownership of the provided WebScrollbar and WebScrollbarThemeGeometry.
-    WEBKIT_EXPORT static WebScrollbarLayer* create(WebScrollbar*, WebScrollbarThemePainter, WebScrollbarThemeGeometry*);
-
     virtual ~WebScrollbarLayer() { }
 
     virtual WebLayer* layer() = 0;

Modified: trunk/Source/Platform/chromium/public/WebSolidColorLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebSolidColorLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebSolidColorLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -34,8 +34,6 @@
 
 class WebSolidColorLayer {
 public:
-    WEBKIT_EXPORT static WebSolidColorLayer* create();
-
     virtual ~WebSolidColorLayer() { }
 
     virtual WebLayer* layer() = 0;

Modified: trunk/Source/Platform/chromium/public/WebTransformAnimationCurve.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebTransformAnimationCurve.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebTransformAnimationCurve.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -36,8 +36,6 @@
 // A keyframed transform animation curve.
 class WebTransformAnimationCurve : public WebAnimationCurve {
 public:
-    WEBKIT_EXPORT static WebTransformAnimationCurve* create();
-
     virtual ~WebTransformAnimationCurve() { }
 
     // Adds the keyframe with the default timing function (ease).

Modified: trunk/Source/Platform/chromium/public/WebVideoLayer.h (138830 => 138831)


--- trunk/Source/Platform/chromium/public/WebVideoLayer.h	2013-01-04 20:25:34 UTC (rev 138830)
+++ trunk/Source/Platform/chromium/public/WebVideoLayer.h	2013-01-04 20:25:40 UTC (rev 138831)
@@ -35,8 +35,6 @@
 
 class WebVideoLayer {
 public:
-    WEBKIT_EXPORT static WebVideoLayer* create(WebVideoFrameProvider*);
-
     virtual ~WebVideoLayer() { }
 
     virtual WebLayer* layer() = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to