Title: [138720] trunk/Source/WebCore
- Revision
- 138720
- Author
- tse...@chromium.org
- Date
- 2013-01-03 10:48:41 -0800 (Thu, 03 Jan 2013)
Log Message
PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods.
https://bugs.webkit.org/show_bug.cgi?id=105975
Reviewed by Nate Chapin.
Change adds compile-time checks only, so no new tests.
* loader/PingLoader.h:
(PingLoader):
(WebCore::PingLoader::timeout):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138719 => 138720)
--- trunk/Source/WebCore/ChangeLog 2013-01-03 18:42:20 UTC (rev 138719)
+++ trunk/Source/WebCore/ChangeLog 2013-01-03 18:48:41 UTC (rev 138720)
@@ -1,3 +1,16 @@
+2013-01-03 Tom Sepez <tse...@chromium.org>
+
+ PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods.
+ https://bugs.webkit.org/show_bug.cgi?id=105975
+
+ Reviewed by Nate Chapin.
+
+ Change adds compile-time checks only, so no new tests.
+
+ * loader/PingLoader.h:
+ (PingLoader):
+ (WebCore::PingLoader::timeout):
+
2013-01-02 Levi Weintraub <le...@chromium.org>
Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
Modified: trunk/Source/WebCore/loader/PingLoader.h (138719 => 138720)
--- trunk/Source/WebCore/loader/PingLoader.h 2013-01-03 18:42:20 UTC (rev 138719)
+++ trunk/Source/WebCore/loader/PingLoader.h 2013-01-03 18:48:41 UTC (rev 138720)
@@ -58,17 +58,17 @@
static void sendPing(Frame*, const KURL& pingURL, const KURL& destinationURL);
static void sendViolationReport(Frame*, const KURL& reportURL, PassRefPtr<FormData> report);
- ~PingLoader();
+ virtual ~PingLoader();
private:
PingLoader(Frame*, ResourceRequest&);
- void didReceiveResponse(ResourceHandle*, const ResourceResponse&) { delete this; }
- void didReceiveData(ResourceHandle*, const char*, int, int) { delete this; }
- void didFinishLoading(ResourceHandle*, double) { delete this; }
- void didFail(ResourceHandle*, const ResourceError&) { delete this; }
+ virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&) OVERRIDE { delete this; }
+ virtual void didReceiveData(ResourceHandle*, const char*, int, int) OVERRIDE { delete this; }
+ virtual void didFinishLoading(ResourceHandle*, double) OVERRIDE { delete this; }
+ virtual void didFail(ResourceHandle*, const ResourceError&) OVERRIDE { delete this; }
+ virtual bool shouldUseCredentialStorage(ResourceHandle*) OVERRIDE { return m_shouldUseCredentialStorage; }
void timeout(Timer<PingLoader>*) { delete this; }
- bool shouldUseCredentialStorage(ResourceHandle*) { return m_shouldUseCredentialStorage; }
RefPtr<ResourceHandle> m_handle;
Timer<PingLoader> m_timeout;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
