Title: [138038] trunk/Tools
- Revision
- 138038
- Author
- commit-qu...@webkit.org
- Date
- 2012-12-18 10:32:21 -0800 (Tue, 18 Dec 2012)
Log Message
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318
Patch by Alberto Garcia <agar...@igalia.com> on 2012-12-18
Reviewed by Martin Robinson.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
Consider log lines that end with TIMEOUT as errors.
* Scripts/run-gtk-tests:
(TestRunner.run_tests):
Consider timeouts as failures when returning the number of failed
tests.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (138037 => 138038)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-18 18:23:15 UTC (rev 138037)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-18 18:32:21 UTC (rev 138038)
@@ -542,7 +542,7 @@
logText = cmd.logs['stdio'].getText()
incorrectLines = []
for line in logText.splitlines():
- if line.startswith('ERROR'):
+ if line.startswith('ERROR') or line.endswith('TIMEOUT\n'):
incorrectLines.append(line)
self.incorrectLines = incorrectLines
Modified: trunk/Tools/ChangeLog (138037 => 138038)
--- trunk/Tools/ChangeLog 2012-12-18 18:23:15 UTC (rev 138037)
+++ trunk/Tools/ChangeLog 2012-12-18 18:32:21 UTC (rev 138038)
@@ -1,3 +1,19 @@
+2012-12-18 Alberto Garcia <agar...@igalia.com>
+
+ [GTK] Tests that time out are not considered as failures.
+ https://bugs.webkit.org/show_bug.cgi?id=105318
+
+ Reviewed by Martin Robinson.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunGtkAPITests.commandComplete):
+ Consider log lines that end with TIMEOUT as errors.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner.run_tests):
+ Consider timeouts as failures when returning the number of failed
+ tests.
+
2012-12-18 Pravin D <pravi...@samsung.com>
Unreviewed, adding secondary email.
Modified: trunk/Tools/Scripts/run-gtk-tests (138037 => 138038)
--- trunk/Tools/Scripts/run-gtk-tests 2012-12-18 18:23:15 UTC (rev 138037)
+++ trunk/Tools/Scripts/run-gtk-tests 2012-12-18 18:32:21 UTC (rev 138038)
@@ -347,7 +347,7 @@
sys.stdout.write("Tests skipped:\n%s\n" % "\n".join([str(skipped) for skipped in self._skipped_tests]))
sys.stdout.flush()
- return len(failed_tests)
+ return len(failed_tests) + len(timed_out_tests)
if __name__ == "__main__":
if not jhbuildutils.enter_jhbuild_environment_if_available("gtk"):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
