Title: [137490] trunk/Source/WebKit/chromium
- Revision
- 137490
- Author
- [email protected]
- Date
- 2012-12-12 11:32:12 -0800 (Wed, 12 Dec 2012)
Log Message
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704
Reviewed by James Robinson.
Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://chromiumcodereview.appspot.com/10990121/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137489 => 137490)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-12 19:32:12 UTC (rev 137490)
@@ -1,3 +1,23 @@
+2012-12-12 Mark Pilgrim <[email protected]>
+
+ [Chromium] Remove all references to sharedWorkerRepository()
+ https://bugs.webkit.org/show_bug.cgi?id=104704
+
+ Reviewed by James Robinson.
+
+ Now that Chromium calls setSharedWorkerRepository upon
+ initializing WebKit (
+ https://chromiumcodereview.appspot.com/10990121/ ) and no longer
+ tries to override sharedWorkerRepository, it is safe to remove
+ all references to this function.
+
+ * public/platform/WebKitPlatformSupport.h:
+ (WebKit):
+ (WebKit::WebKitPlatformSupport::idbFactory):
+ * src/SharedWorkerRepository.cpp:
+ (WebKit::sharedWorkerRepository):
+ (WebCore::SharedWorkerRepository::isAvailable):
+
2012-12-12 Tommy Widenflycht <[email protected]>
MediaStream API: Change the data channel descriptor pattern to a handler pattern
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (137489 => 137490)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-12 19:32:12 UTC (rev 137490)
@@ -36,7 +36,6 @@
namespace WebKit {
class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
// FIXME: Eventually all these API will need to move to WebKit::Platform.
class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
virtual WebIDBFactory* idbFactory() { return 0; }
-
- // Shared Workers ------------------------------------------------------
-
- virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
protected:
~WebKitPlatformSupport() { }
};
Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (137489 => 137490)
--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-12 19:32:12 UTC (rev 137490)
@@ -69,15 +69,8 @@
static WebSharedWorkerRepository* sharedWorkerRepository()
{
- WebSharedWorkerRepository* repository;
-
- repository = s_sharedWorkerRepository;
- if (!repository) {
- repository = webKitPlatformSupport()->sharedWorkerRepository();
- setSharedWorkerRepository(repository);
- }
-
- return repository;
+ // Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+ return s_sharedWorkerRepository;
}
}
@@ -218,8 +211,6 @@
bool SharedWorkerRepository::isAvailable()
{
- // Allow the WebKitPlatformSupport to determine if SharedWorkers
- // are available.
return WebKit::sharedWorkerRepository();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
