Title: [137206] trunk/Source/WebCore
Revision
137206
Author
[email protected]
Date
2012-12-10 14:15:01 -0800 (Mon, 10 Dec 2012)

Log Message

Deprecate prefixed linear-gradient and radial-gradient functions
https://bugs.webkit.org/show_bug.cgi?id=104591

Patch by Tab Atkins <[email protected]> on 2012-12-10
Reviewed by Dean Jackson.

Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.

No new tests added - this is a rename and has no functionality change.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseGeneratedImage):
* css/CSSParser.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (137205 => 137206)


--- trunk/Source/WebCore/ChangeLog	2012-12-10 22:14:33 UTC (rev 137205)
+++ trunk/Source/WebCore/ChangeLog	2012-12-10 22:15:01 UTC (rev 137206)
@@ -1,3 +1,20 @@
+2012-12-10  Tab Atkins  <[email protected]>
+
+        Deprecate prefixed linear-gradient and radial-gradient functions
+        https://bugs.webkit.org/show_bug.cgi?id=104591
+
+        Reviewed by Dean Jackson.
+
+        Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.
+
+        No new tests added - this is a rename and has no functionality change.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseDeprecatedLinearGradient):
+        (WebCore::CSSParser::parseDeprecatedRadialGradient):
+        (WebCore::CSSParser::parseGeneratedImage):
+        * css/CSSParser.h:
+
 2012-12-10  Mark Pilgrim  <[email protected]>
 
         [Chromium][Win] Remove theme-related functions from PlatformSupport

Modified: trunk/Source/WebCore/css/CSSParser.cpp (137205 => 137206)


--- trunk/Source/WebCore/css/CSSParser.cpp	2012-12-10 22:14:33 UTC (rev 137205)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-12-10 22:15:01 UTC (rev 137206)
@@ -7120,7 +7120,7 @@
     return p->parseColor(value);
 }
 
-bool CSSParser::parseLinearGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
+bool CSSParser::parseDeprecatedLinearGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
 {
     RefPtr<CSSLinearGradientValue> result = CSSLinearGradientValue::create(repeating);
 
@@ -7188,7 +7188,7 @@
     return true;
 }
 
-bool CSSParser::parseRadialGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
+bool CSSParser::parseDeprecatedRadialGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
 {
     RefPtr<CSSRadialGradientValue> result = CSSRadialGradientValue::create(repeating);
 
@@ -7370,16 +7370,16 @@
         return parseDeprecatedGradient(valueList, value);
 
     if (equalIgnoringCase(val->function->name, "-webkit-linear-gradient("))
-        return parseLinearGradient(valueList, value, NonRepeating);
+        return parseDeprecatedLinearGradient(valueList, value, NonRepeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-repeating-linear-gradient("))
-        return parseLinearGradient(valueList, value, Repeating);
+        return parseDeprecatedLinearGradient(valueList, value, Repeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-radial-gradient("))
-        return parseRadialGradient(valueList, value, NonRepeating);
+        return parseDeprecatedRadialGradient(valueList, value, NonRepeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-repeating-radial-gradient("))
-        return parseRadialGradient(valueList, value, Repeating);
+        return parseDeprecatedRadialGradient(valueList, value, Repeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-canvas("))
         return parseCanvas(valueList, value);

Modified: trunk/Source/WebCore/css/CSSParser.h (137205 => 137206)


--- trunk/Source/WebCore/css/CSSParser.h	2012-12-10 22:14:33 UTC (rev 137205)
+++ trunk/Source/WebCore/css/CSSParser.h	2012-12-10 22:15:01 UTC (rev 137206)
@@ -212,8 +212,8 @@
     bool parseCanvas(CSSParserValueList*, RefPtr<CSSValue>&);
 
     bool parseDeprecatedGradient(CSSParserValueList*, RefPtr<CSSValue>&);
-    bool parseLinearGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
-    bool parseRadialGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
+    bool parseDeprecatedLinearGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
+    bool parseDeprecatedRadialGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
     bool parseGradientColorStops(CSSParserValueList*, CSSGradientValue*, bool expectComma);
 
     bool parseCrossfade(CSSParserValueList*, RefPtr<CSSValue>&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to