Title: [137113] trunk
Revision
137113
Author
commit-qu...@webkit.org
Date
2012-12-10 00:04:49 -0800 (Mon, 10 Dec 2012)

Log Message

[GTK] accessibility/editable-webarea-context-menu-point.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98364

Patch by Joanmarie Diggs <jdi...@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Tools:

The test is failing because the clickPoint values remain unchanged. The
values remain unchanged because ATK lacks a means to keep track of this
information.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
(AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details

LayoutTests:

This test seems to be Mac-specific. Therefore, move the test to that
platform and remove the skips from the other platforms.

* platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
* platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
* platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (137112 => 137113)


--- trunk/LayoutTests/ChangeLog	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/ChangeLog	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1,3 +1,22 @@
+2012-12-10  Joanmarie Diggs  <jdi...@igalia.com>
+
+        [GTK] accessibility/editable-webarea-context-menu-point.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98364
+
+        Reviewed by Chris Fleizach.
+
+        This test seems to be Mac-specific. Therefore, move the test to that
+        platform and remove the skips from the other platforms.
+
+        * platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
+        * platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
+        * platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
+        * platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html
+
 2012-12-09  Takashi Sakamoto  <ta...@google.com>
 
         [Shadow DOM]: reset-style-inheritance doesn't work for insertion point

Deleted: trunk/LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt (137112 => 137113)


--- trunk/LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1,11 +0,0 @@
-This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area. This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
-This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area (by setting the selection twice and comparing the click point locations)
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS succeeded is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Deleted: trunk/LayoutTests/accessibility/editable-webarea-context-menu-point.html (137112 => 137113)


--- trunk/LayoutTests/accessibility/editable-webarea-context-menu-point.html	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/accessibility/editable-webarea-context-menu-point.html	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1,54 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body id="body" contenteditable>
-This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
-This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
-
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
-
-    description("This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area (by setting the selection twice and comparing the click point locations)");
-
-    if (window.accessibilityController) {
-
-          var body = document.getElementById("body");
-          body.focus();
-          var axWebArea = accessibilityController.focusedElement.parentElement();
-
-          x = body.offsetLeft + 10;
-          y = body.offsetTop + 10;
-
-          eventSender.mouseMoveTo(x, y);
-          eventSender.mouseDown();
-          eventSender.mouseUp();
-          eventSender.mouseDown();
-          eventSender.mouseUp();
-
-          var clickPointX1 = axWebArea.clickPointX;
-
-          x = body.offsetLeft + 100 + 10;
-          y = body.offsetTop + 10;
-
-          eventSender.mouseMoveTo(x, y);
-          eventSender.mouseDown();
-          eventSender.mouseUp();
-          eventSender.mouseDown();
-          eventSender.mouseUp();
-
-          var clickPointX2 = axWebArea.clickPointX;
-          var succeeded = clickPointX2 != clickPointX1;
-          shouldBe("succeeded", "true");
-
-    }
-
-</script>
-
-<script src=""
-</body>
-</html>

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1405,7 +1405,6 @@
 crbug.com/10322 accessibility/button-press-action.html [ Skip ]
 crbug.com/10322 accessibility/deleting-iframe-destroys-axcache.html [ Skip ]
 crbug.com/10322 accessibility/document-attributes.html [ Skip ]
-crbug.com/10322 accessibility/editable-webarea-context-menu-point.html [ Skip ]
 crbug.com/10322 accessibility/iframe-bastardization.html [ Skip ]
 crbug.com/10322 accessibility/image-link.html [ Skip ]
 crbug.com/10322 accessibility/image-map-update-parent-crash.html [ Skip ]

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -232,7 +232,6 @@
 accessibility/canvas-fallback-content-2.html [ Skip ]
 accessibility/canvas-fallback-content.html [ Skip ]
 accessibility/disabled-controls-not-focusable.html [ Skip ]
-accessibility/editable-webarea-context-menu-point.html [ Skip ]
 accessibility/ellipsis-text.html [ Skip ]
 accessibility/file-upload-button-with-axpress.html [ Skip ]
 accessibility/hidden-legend.html [ Skip ]

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -744,7 +744,6 @@
 webkit.org/b/98360 accessibility/aria-used-on-image-maps.html [ Failure ]
 webkit.org/b/98361 accessibility/button-press-action.html [ Failure ]
 webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
-webkit.org/b/98364 accessibility/editable-webarea-context-menu-point.html [ Failure ]
 webkit.org/b/98365 accessibility/ellipsis-text.html [ Failure ]
 webkit.org/b/98369 accessibility/language-attribute.html [ Failure ]
 webkit.org/b/98370 accessibility/loading-iframe-sends-notification.html [ Failure ]

Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -50,7 +50,6 @@
 # [GTK] Implement drag and drop support in WebKit2
 # https://bugs.webkit.org/show_bug.cgi?id=63706
 # Implement EditingCallbacks deletegates in the WebKitTestRunner
-webkit.org/b/63706 accessibility/editable-webarea-context-menu-point.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/4947130.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/dataTransfer-setData-getData.html [ Failure Timeout ]
 webkit.org/b/63706 editing/pasteboard/drag-and-drop-image-contenteditable.html [ Failure Timeout ]

Copied: trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt (from rev 137112, trunk/LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt) (0 => 137113)


--- trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt	2012-12-10 08:04:49 UTC (rev 137113)
@@ -0,0 +1,11 @@
+This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area. This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
+This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area (by setting the selection twice and comparing the click point locations)
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS succeeded is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Copied: trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html (from rev 137112, trunk/LayoutTests/accessibility/editable-webarea-context-menu-point.html) (0 => 137113)


--- trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html	                        (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html	2012-12-10 08:04:49 UTC (rev 137113)
@@ -0,0 +1,54 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body" contenteditable>
+This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
+This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area.
+
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+    description("This tests that the click point, used for opening context menus, changes based on the current selection in an editable web area (by setting the selection twice and comparing the click point locations)");
+
+    if (window.accessibilityController) {
+
+          var body = document.getElementById("body");
+          body.focus();
+          var axWebArea = accessibilityController.focusedElement.parentElement();
+
+          x = body.offsetLeft + 10;
+          y = body.offsetTop + 10;
+
+          eventSender.mouseMoveTo(x, y);
+          eventSender.mouseDown();
+          eventSender.mouseUp();
+          eventSender.mouseDown();
+          eventSender.mouseUp();
+
+          var clickPointX1 = axWebArea.clickPointX;
+
+          x = body.offsetLeft + 100 + 10;
+          y = body.offsetTop + 10;
+
+          eventSender.mouseMoveTo(x, y);
+          eventSender.mouseDown();
+          eventSender.mouseUp();
+          eventSender.mouseDown();
+          eventSender.mouseUp();
+
+          var clickPointX2 = axWebArea.clickPointX;
+          var succeeded = clickPointX2 != clickPointX1;
+          shouldBe("succeeded", "true");
+
+    }
+
+</script>
+
+<script src=""
+</body>
+</html>

Modified: trunk/LayoutTests/platform/win/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/win/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/win/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -618,7 +618,6 @@
 accessibility/aria-used-on-image-maps.html
 accessibility/button-press-action.html
 accessibility/document-attributes.html
-accessibility/editable-webarea-context-menu-point.html
 accessibility/hidden-legend.html
 accessibility/ignore-spacer-elements.html
 accessibility/image-link.html

Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (137112 => 137113)


--- trunk/LayoutTests/platform/wincairo/TestExpectations	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1146,7 +1146,6 @@
 accessibility/aria-used-on-image-maps.html
 accessibility/button-press-action.html
 accessibility/document-attributes.html
-accessibility/editable-webarea-context-menu-point.html
 accessibility/hidden-legend.html
 accessibility/ignore-spacer-elements.html
 accessibility/image-link.html

Modified: trunk/Tools/ChangeLog (137112 => 137113)


--- trunk/Tools/ChangeLog	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/Tools/ChangeLog	2012-12-10 08:04:49 UTC (rev 137113)
@@ -1,3 +1,18 @@
+2012-12-10  Joanmarie Diggs  <jdi...@igalia.com>
+
+        [GTK] accessibility/editable-webarea-context-menu-point.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98364
+
+        Reviewed by Chris Fleizach.
+
+        The test is failing because the clickPoint values remain unchanged. The
+        values remain unchanged because ATK lacks a means to keep track of this
+        information.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
+        (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
+
 2012-12-09  Alejandro PiƱeiro  <apinhe...@igalia.com>
 
         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable

Modified: trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (137112 => 137113)


--- trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp	2012-12-10 07:43:42 UTC (rev 137112)
+++ trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp	2012-12-10 08:04:49 UTC (rev 137113)
@@ -478,11 +478,13 @@
 
 double AccessibilityUIElement::clickPointX()
 {
+    // Note: This is not something we have in ATK.
     return 0.f;
 }
 
 double AccessibilityUIElement::clickPointY()
 {
+    // Note: This is not something we have in ATK.
     return 0.f;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to