Title: [136961] trunk/Source/WebKit/blackberry
- Revision
- 136961
- Author
- commit-qu...@webkit.org
- Date
- 2012-12-07 10:16:11 -0800 (Fri, 07 Dec 2012)
Log Message
[BlackBerry] Double zoom animation when focusing on input field.
https://bugs.webkit.org/show_bug.cgi?id=104375
Patch by Andrew Lo <a...@rim.com> on 2012-12-07
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
UI thread does not need to be notified of a scale change if the WebKit
thread scale has not changed.
This caused issues when two viewport resizes occured one after the other.
Before the scale change due to the first resize could be set in the WK
thread's scale value, it caused WK thread to dispatch a scaleChanged,
overwritting & resetting the new UI thread scale value, resulting in the
double zoom animation.
The larger issue dealing with synchronization between the threads where
scale changes could occur on either thread, however that is beyond the
scope of this change.
Internal PR253122
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (136960 => 136961)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-12-07 18:07:59 UTC (rev 136960)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-12-07 18:16:11 UTC (rev 136961)
@@ -1184,10 +1184,8 @@
ASSERT(clampedScale);
*clampedScale = scale;
- if (currentScale() == scale) {
- m_client->scaleChanged();
+ if (currentScale() == scale)
return false;
- }
return true;
}
Modified: trunk/Source/WebKit/blackberry/ChangeLog (136960 => 136961)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 18:07:59 UTC (rev 136960)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 18:16:11 UTC (rev 136961)
@@ -1,3 +1,29 @@
+2012-12-07 Andrew Lo <a...@rim.com>
+
+ [BlackBerry] Double zoom animation when focusing on input field.
+ https://bugs.webkit.org/show_bug.cgi?id=104375
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Jakob Petsovits.
+
+ UI thread does not need to be notified of a scale change if the WebKit
+ thread scale has not changed.
+
+ This caused issues when two viewport resizes occured one after the other.
+ Before the scale change due to the first resize could be set in the WK
+ thread's scale value, it caused WK thread to dispatch a scaleChanged,
+ overwritting & resetting the new UI thread scale value, resulting in the
+ double zoom animation.
+
+ The larger issue dealing with synchronization between the threads where
+ scale changes could occur on either thread, however that is beyond the
+ scope of this change.
+
+ Internal PR253122
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
+
2012-12-07 Xiaobo Wang <xbw...@torchmobile.com.cn>
[BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
