Title: [136916] trunk/Websites/bugs.webkit.org
- Revision
- 136916
- Author
- o...@chromium.org
- Date
- 2012-12-06 18:30:17 -0800 (Thu, 06 Dec 2012)
Log Message
Review page is super flakey now
https://bugs.webkit.org/show_bug.cgi?id=104331
Committing without review since this is breaking the code review tool.
remove is only shipping in Chromium. Use jQuery's remove instead.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (136915 => 136916)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2012-12-07 02:18:01 UTC (rev 136915)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2012-12-07 02:30:17 UTC (rev 136916)
@@ -1,3 +1,15 @@
+2012-12-06 Ojan Vafai <o...@chromium.org>
+
+ Review page is super flakey now
+ https://bugs.webkit.org/show_bug.cgi?id=104331
+
+ Committing without review since this is breaking the code review tool.
+
+ remove is only shipping in Chromium. Use jQuery's remove instead.
+
+ * PrettyPatch/PrettyPatch.rb:
+ * code-review.js:
+
2012-12-05 Ojan Vafai <o...@chromium.org>
Make the strip line numbers link into a checkbox
Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (136915 => 136916)
--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2012-12-07 02:18:01 UTC (rev 136915)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2012-12-07 02:30:17 UTC (rev 136916)
@@ -506,7 +506,7 @@
}
</style>
<script src=""
-<script src=""
+<script src=""
</head>
EOF
Modified: trunk/Websites/bugs.webkit.org/code-review.js (136915 => 136916)
--- trunk/Websites/bugs.webkit.org/code-review.js 2012-12-07 02:18:01 UTC (rev 136915)
+++ trunk/Websites/bugs.webkit.org/code-review.js 2012-12-07 02:30:17 UTC (rev 136916)
@@ -1160,7 +1160,7 @@
classesToRemove.forEach(function(className) {
forEachNode(fragment.querySelectorAll('.' + className), function(node) {
- node.remove();
+ $(node).remove();
});
});
@@ -1188,7 +1188,7 @@
selection.selectAllChildren(container);
setTimeout(function() {
- container.remove();
+ $(container).remove();
selection.removeAllRanges();
selection.addRange(range);
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
