Title: [136879] trunk/Tools
Revision
136879
Author
fpi...@apple.com
Date
2012-12-06 13:20:30 -0800 (Thu, 06 Dec 2012)

Log Message

Profiler should print a helpful message if you pass the wrong arguments
https://bugs.webkit.org/show_bug.cgi?id=104222

Reviewed by Oliver Hunt.

* Scripts/display-profiler-output:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (136878 => 136879)


--- trunk/Tools/ChangeLog	2012-12-06 21:19:12 UTC (rev 136878)
+++ trunk/Tools/ChangeLog	2012-12-06 21:20:30 UTC (rev 136879)
@@ -1,3 +1,12 @@
+2012-12-05  Filip Pizlo  <fpi...@apple.com>
+
+        Profiler should print a helpful message if you pass the wrong arguments
+        https://bugs.webkit.org/show_bug.cgi?id=104222
+
+        Reviewed by Oliver Hunt.
+
+        * Scripts/display-profiler-output:
+
 2012-12-06  Ojan Vafai  <o...@chromium.org>
 
         Allow for CCing a secondary email address from watchlists

Modified: trunk/Tools/Scripts/display-profiler-output (136878 => 136879)


--- trunk/Tools/Scripts/display-profiler-output	2012-12-06 21:19:12 UTC (rev 136878)
+++ trunk/Tools/Scripts/display-profiler-output	2012-12-06 21:20:30 UTC (rev 136879)
@@ -265,6 +265,16 @@
     end
 end
 
+if ARGV.length != 1
+    $stderr.puts "Usage: display-profiler-output <path to profiler output file>"
+    $stderr.puts
+    $stderr.puts "The typical usage pattern for the profiler currently looks something like:"
+    $stderr.puts
+    $stderr.puts "Path/To/jsc -p profile.json myprogram.js"
+    $stderr.puts "display-profiler-output profile.json"
+    exit 1
+end
+
 $json = JSON::parse(IO::read(ARGV[0]))
 $bytecodes = $json["bytecodes"].map {
     | subJson |
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to