Title: [136743] trunk/Tools
Revision
136743
Author
commit-qu...@webkit.org
Date
2012-12-05 12:55:53 -0800 (Wed, 05 Dec 2012)

Log Message

Remove stale check in check-for-webkit-framework-include-consistency
https://bugs.webkit.org/show_bug.cgi?id=103775

Patch by Joseph Pecoraro <pecor...@apple.com> on 2012-12-05
Reviewed by David Kilzer.

The underlying issue was fixed in r81173.

* Scripts/check-for-webkit-framework-include-consistency:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (136742 => 136743)


--- trunk/Tools/ChangeLog	2012-12-05 20:53:24 UTC (rev 136742)
+++ trunk/Tools/ChangeLog	2012-12-05 20:55:53 UTC (rev 136743)
@@ -1,3 +1,14 @@
+2012-12-05  Joseph Pecoraro  <pecor...@apple.com>
+
+        Remove stale check in check-for-webkit-framework-include-consistency
+        https://bugs.webkit.org/show_bug.cgi?id=103775
+
+        Reviewed by David Kilzer.
+
+        The underlying issue was fixed in r81173.
+
+        * Scripts/check-for-webkit-framework-include-consistency:
+
 2012-12-05  Dirk Pranke  <dpra...@chromium.org>
 
         nrwt: simplify the finding of tests to retry

Modified: trunk/Tools/Scripts/check-for-webkit-framework-include-consistency (136742 => 136743)


--- trunk/Tools/Scripts/check-for-webkit-framework-include-consistency	2012-12-05 20:53:24 UTC (rev 136742)
+++ trunk/Tools/Scripts/check-for-webkit-framework-include-consistency	2012-12-05 20:55:53 UTC (rev 136743)
@@ -27,10 +27,6 @@
 base_directory = ENV['TARGET_BUILD_DIR'] or throw "Unable to find TARGET_BUILD_DIR in the environment!"
 is_shallow_bundle = (ENV['SHALLOW_BUNDLE'] || "NO").upcase == "YES"
 
-unless base_directory
-  throw "Unable to find TARGET_BUILD_DIR in the environment!"
-end
-
 Dir.chdir base_directory
 
 $PERMITTED_INCLUDE_TYPES = { :public => [ :public ], :private => [ :public, :private ] }
@@ -73,9 +69,6 @@
 
   # A header of any type including a WebCore header is a recipe for disaster.
   if framework == "WebCore"
-    # <rdar://problem/7718826> WebKeyGenerator.h should not include a WebCore header
-    return if header =~ /\/WebKeyGenerator.h$/ and included_header_name == "WebCoreKeyGenerator.h"
-
     print_error "#{header} included #{included_header}!"
     return
   end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to