Title: [136654] trunk/Source/WebKit2
- Revision
- 136654
- Author
- [email protected]
- Date
- 2012-12-05 01:38:32 -0800 (Wed, 05 Dec 2012)
Log Message
[EFL][WK2] Add APIs to get/set private browsing.
https://bugs.webkit.org/show_bug.cgi?id=102052
Patch by Yuni Jeong <[email protected]> on 2012-12-05
Reviewed by Gyuyoung Kim.
Private Browsing allows a user to browse the Internet without saving any information about which sites and pages a user has visited.
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (136653 => 136654)
--- trunk/Source/WebKit2/ChangeLog 2012-12-05 09:03:53 UTC (rev 136653)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-05 09:38:32 UTC (rev 136654)
@@ -1,3 +1,19 @@
+2012-12-05 Yuni Jeong <[email protected]>
+
+ [EFL][WK2] Add APIs to get/set private browsing.
+ https://bugs.webkit.org/show_bug.cgi?id=102052
+
+ Reviewed by Gyuyoung Kim.
+
+ Private Browsing allows a user to browse the Internet without saving any information about which sites and pages a user has visited.
+
+ * UIProcess/API/efl/ewk_settings.cpp:
+ (ewk_settings_private_browsing_enabled_set):
+ (ewk_settings_private_browsing_enabled_get):
+ * UIProcess/API/efl/ewk_settings.h:
+ * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+ (TEST_F):
+
2012-12-05 Joaquim Rocha <[email protected]>
URL schemes registered as local, no access, display isolated and as CORS enabled are not registered again after a web process crash
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp (136653 => 136654)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-12-05 09:03:53 UTC (rev 136653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-12-05 09:38:32 UTC (rev 136654)
@@ -380,3 +380,19 @@
return settings->preferences()->defaultFontSize();
}
+
+Eina_Bool ewk_settings_private_browsing_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
+{
+ EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+ settings->preferences()->setPrivateBrowsingEnabled(enable);
+
+ return true;
+}
+
+Eina_Bool ewk_settings_private_browsing_enabled_get(const Ewk_Settings* settings)
+{
+ EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+ return settings->preferences()->privateBrowsingEnabled();
+}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h (136653 => 136654)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-12-05 09:03:53 UTC (rev 136653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-12-05 09:38:32 UTC (rev 136654)
@@ -468,6 +468,32 @@
*/
EAPI int ewk_settings_default_font_size_get(const Ewk_Settings *settings);
+/**
+ * Enables/disables private browsing.
+ *
+ * By default, private browsing is disabled.
+ *
+ * @param settings settings object to set private browsing
+ * @param enable @c EINA_TRUE to enable private browsing
+ * @c EINA_FALSE to disable
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_settings_private_browsing_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
+
+/**
+ * Returns whether private browsing is enabled or not.
+ *
+ * Private Browsing allows a user to browse the Internet without saving any information
+ * about which sites and pages a user has visited.
+ *
+ * @param settings settings object to query whether private browsing is enabled
+ *
+ * @return @c EINA_TRUE if private browsing is enabled
+ * @c EINA_FALSE if not or on failure
+ */
+EAPI Eina_Bool ewk_settings_private_browsing_enabled_get(const Ewk_Settings *settings);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (136653 => 136654)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2012-12-05 09:03:53 UTC (rev 136653)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2012-12-05 09:38:32 UTC (rev 136654)
@@ -249,3 +249,17 @@
ASSERT_TRUE(ewk_settings_default_font_size_set(settings, 20));
ASSERT_EQ(20, ewk_settings_default_font_size_get(settings));
}
+
+TEST_F(EWK2UnitTestBase, ewk_settings_private_browsing_enabled)
+{
+ Ewk_Settings* settings = ewk_view_settings_get(webView());
+
+ // Private browsing is disabled by default.
+ ASSERT_FALSE(ewk_settings_private_browsing_enabled_get(settings));
+
+ ASSERT_TRUE(ewk_settings_private_browsing_enabled_set(settings, true));
+ ASSERT_TRUE(ewk_settings_private_browsing_enabled_get(settings));
+
+ ASSERT_TRUE(ewk_settings_private_browsing_enabled_set(settings, false));
+ ASSERT_FALSE(ewk_settings_private_browsing_enabled_get(settings));
+}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
