Title: [136551] trunk/Source/WebCore
- Revision
- 136551
- Author
- aba...@webkit.org
- Date
- 2012-12-04 12:47:49 -0800 (Tue, 04 Dec 2012)
Log Message
[V8] GetNativeType in CodeGeneratorV8.pm needs a bath
https://bugs.webkit.org/show_bug.cgi?id=104022
Reviewed by Eric Seidel.
This change shouldn't have any effect on the generated code.
* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
- DOMUserData was removed in 2005. There's no need for the code
generator to still know about it.
(JSValueToNative):
(ConvertToV8StringResource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136550 => 136551)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 20:47:30 UTC (rev 136550)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 20:47:49 UTC (rev 136551)
@@ -1,5 +1,21 @@
2012-12-04 Adam Barth <aba...@webkit.org>
+ [V8] GetNativeType in CodeGeneratorV8.pm needs a bath
+ https://bugs.webkit.org/show_bug.cgi?id=104022
+
+ Reviewed by Eric Seidel.
+
+ This change shouldn't have any effect on the generated code.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GetNativeType):
+ - DOMUserData was removed in 2005. There's no need for the code
+ generator to still know about it.
+ (JSValueToNative):
+ (ConvertToV8StringResource):
+
+2012-12-04 Adam Barth <aba...@webkit.org>
+
[V8] EventTarget shouldn't be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=104018
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (136550 => 136551)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-04 20:47:30 UTC (rev 136550)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-04 20:47:49 UTC (rev 136551)
@@ -3689,49 +3689,38 @@
}
}
- if ($type eq "float" or $type eq "double") {
- return $type;
- }
-
- return "V8StringResource" if ($type eq "DOMString" or $type eq "DOMUserData") and $isParameter;
- return "int" if $type eq "int";
- return "int" if $type eq "short" or $type eq "unsigned short";
- return "unsigned" if $type eq "unsigned long";
- return "int" if $type eq "long";
+ return "float" if $type eq "float";
+ return "double" if $type eq "double";
+ return "int" if $type eq "long" or $type eq "int" or $type eq "short" or $type eq "unsigned short";
+ return "unsigned" if $type eq "unsigned long" or $type eq "unsigned int";
return "long long" if $type eq "long long";
return "unsigned long long" if $type eq "unsigned long long";
return "bool" if $type eq "boolean";
+
+ return "V8StringResource" if $type eq "DOMString" and $isParameter;
return "String" if $type eq "DOMString";
+
return "Range::CompareHow" if $type eq "CompareHow";
return "DOMTimeStamp" if $type eq "DOMTimeStamp";
- return "unsigned" if $type eq "unsigned int";
+ return "double" if $type eq "Date";
+
# FIXME: When EventTarget is an interface and not a mixin, fix this so that
# EventTarget can be passed as a parameter.
return "Node*" if $type eq "EventTarget" and $isParameter;
- return "double" if $type eq "Date";
+
return "ScriptValue" if $type eq "DOMObject" or $type eq "any";
return "Dictionary" if $type eq "Dictionary";
- return "String" if $type eq "DOMUserData"; # FIXME: Temporary hack?
+ # FIXME: Consider replacing DOMStringList with DOMString[] or sequence<DOMString>.
+ return "RefPtr<DOMStringList>" if $type eq "DOMString[]" or $type eq "DOMStringList";
- # temporary hack
+ return "RefPtr<IDBKey>" if $type eq "IDBKey";
+ return "RefPtr<MediaQueryListListener>" if $type eq "MediaQueryListListener";
return "RefPtr<NodeFilter>" if $type eq "NodeFilter";
-
return "RefPtr<SerializedScriptValue>" if $type eq "SerializedScriptValue";
-
- return "RefPtr<IDBKey>" if $type eq "IDBKey";
-
- # necessary as resolvers could be constructed on fly.
return "RefPtr<XPathNSResolver>" if $type eq "XPathNSResolver";
-
- return "RefPtr<DOMStringList>" if $type eq "DOMString[]";
return "RefPtr<${type}>" if $codeGenerator->IsRefPtrType($type) and not $isParameter;
- return "RefPtr<MediaQueryListListener>" if $type eq "MediaQueryListListener";
-
- # FIXME: Consider replacing DOMStringList with DOMString[] or sequence<DOMString>.
- return "RefPtr<DOMStringList>" if $type eq "DOMStringList";
-
my $arrayType = $codeGenerator->GetArrayType($type);
my $sequenceType = $codeGenerator->GetSequenceType($type);
my $arrayOrSequenceType = $arrayType || $sequenceType;
@@ -3797,7 +3786,7 @@
# FIXME: Consider replacing DOMStringList with DOMString[] or sequence<DOMString>.
return "toDOMStringList($value)" if $type eq "DOMString[]";
- if ($type eq "DOMString" or $type eq "DOMUserData") {
+ if ($type eq "DOMString") {
return $value;
}
@@ -4205,7 +4194,6 @@
$macro .= "_$suffix" if $suffix;
return "$macro($nativeType, $variableName, $value);"
} else {
- # Don't know how to properly check for conversion exceptions when $parameter->type is "DOMUserData"
return "$nativeType $variableName($value, true);";
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
