Title: [136511] trunk/Source/Platform
- Revision
- 136511
- Author
- commit-qu...@webkit.org
- Date
- 2012-12-04 08:52:01 -0800 (Tue, 04 Dec 2012)
Log Message
Gut WebRenderingStats since we no longer use its member variables.
https://bugs.webkit.org/show_bug.cgi?id=103460
Patch by Glenn Hartmann <hartma...@chromium.org> on 2012-12-04
Reviewed by Darin Fisher.
This was used as an intermediate location to move stats from
chromium's RenderStats. The chromium code has been updated to
remove this dependency (see https://codereview.chromium.org/11364221/).
* chromium/public/WebRenderingStats.h:
(WebKit::WebRenderingStats::WebRenderingStats):
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (136510 => 136511)
--- trunk/Source/Platform/ChangeLog 2012-12-04 16:25:22 UTC (rev 136510)
+++ trunk/Source/Platform/ChangeLog 2012-12-04 16:52:01 UTC (rev 136511)
@@ -1,3 +1,17 @@
+2012-12-04 Glenn Hartmann <hartma...@chromium.org>
+
+ Gut WebRenderingStats since we no longer use its member variables.
+ https://bugs.webkit.org/show_bug.cgi?id=103460
+
+ Reviewed by Darin Fisher.
+
+ This was used as an intermediate location to move stats from
+ chromium's RenderStats. The chromium code has been updated to
+ remove this dependency (see https://codereview.chromium.org/11364221/).
+
+ * chromium/public/WebRenderingStats.h:
+ (WebKit::WebRenderingStats::WebRenderingStats):
+
2012-12-03 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r136460.
Modified: trunk/Source/Platform/chromium/public/WebRenderingStats.h (136510 => 136511)
--- trunk/Source/Platform/chromium/public/WebRenderingStats.h 2012-12-04 16:25:22 UTC (rev 136510)
+++ trunk/Source/Platform/chromium/public/WebRenderingStats.h 2012-12-04 16:52:01 UTC (rev 136511)
@@ -29,60 +29,9 @@
namespace WebKit {
struct WebRenderingStats {
- int numAnimationFrames;
- int numFramesSentToScreen;
- int droppedFrameCount;
- double totalPaintTimeInSeconds;
- double totalRasterizeTimeInSeconds;
- double totalCommitTimeInSeconds;
- size_t totalCommitCount;
- size_t totalPixelsPainted;
- size_t totalPixelsRasterized;
- size_t numImplThreadScrolls;
- size_t numMainThreadScrolls;
-
WebRenderingStats()
- : numAnimationFrames(0)
- , numFramesSentToScreen(0)
- , droppedFrameCount(0)
- , totalPaintTimeInSeconds(0)
- , totalRasterizeTimeInSeconds(0)
- , totalCommitTimeInSeconds(0)
- , totalCommitCount(0)
- , totalPixelsPainted(0)
- , totalPixelsRasterized(0)
- , numImplThreadScrolls(0)
- , numMainThreadScrolls(0)
{
}
-
- // In conjunction with enumerateFields, this allows the embedder to
- // enumerate the values in this structure without
- // having to embed references to its specific member variables. This
- // simplifies the addition of new fields to this type.
- class Enumerator {
- public:
- virtual void addInt(const char* name, int value) = 0;
- virtual void addDouble(const char* name, double value) = 0;
- protected:
- virtual ~Enumerator() { }
- };
-
- // Outputs the fields in this structure to the provided enumerator.
- void enumerateFields(Enumerator* enumerator) const
- {
- enumerator->addInt("numAnimationFrames", numAnimationFrames);
- enumerator->addInt("numFramesSentToScreen", numFramesSentToScreen);
- enumerator->addInt("droppedFrameCount", droppedFrameCount);
- enumerator->addDouble("totalPaintTimeInSeconds", totalPaintTimeInSeconds);
- enumerator->addDouble("totalRasterizeTimeInSeconds", totalRasterizeTimeInSeconds);
- enumerator->addDouble("totalCommitTimeInSeconds", totalCommitTimeInSeconds);
- enumerator->addInt("totalCommitCount", totalCommitCount);
- enumerator->addInt("totalPixelsPainted", totalPixelsPainted);
- enumerator->addInt("totalPixelsRasterized", totalPixelsRasterized);
- enumerator->addInt("numImplThreadScrolls", numImplThreadScrolls);
- enumerator->addInt("numMainThreadScrolls", numMainThreadScrolls);
- }
};
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
