Title: [136415] trunk
Revision
136415
Author
ale...@webkit.org
Date
2012-12-03 10:46:06 -0800 (Mon, 03 Dec 2012)

Log Message

[Mac] Enable CSS3 background-position offset by default.
https://bugs.webkit.org/show_bug.cgi?id=103905

Reviewed by Simon Fraser.

Source/_javascript_Core:

Turn the flag on by default.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Turn the flag on by default.

No new tests : covered by tests landed previously.

* Configurations/FeatureDefines.xcconfig:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillXPosition): Build fix in release on Mac with unused variable.
(WebCore::CSSToStyleMap::mapFillYPosition): Ditto.

Source/WebKit/mac:

Turn the flag on by default.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Turn the flag on by default.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (136414 => 136415)


--- trunk/LayoutTests/ChangeLog	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/LayoutTests/ChangeLog	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1,3 +1,15 @@
+2012-12-03  Alexis Menard  <ale...@webkit.org>
+
+        [Mac] Enable CSS3 background-position offset by default.
+        https://bugs.webkit.org/show_bug.cgi?id=103905
+
+        Reviewed by Simon Fraser.
+
+        Enable by default the new CSS3 background position offsets therefore we
+        can unskip the tests.
+
+        * platform/mac/TestExpectations:
+
 2012-12-03  Takashi Sakamoto  <ta...@google.com>
 
         [style scoped]: style scoped needs more tests.

Modified: trunk/LayoutTests/platform/mac/TestExpectations (136414 => 136415)


--- trunk/LayoutTests/platform/mac/TestExpectations	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1000,10 +1000,6 @@
 webkit.org/b/58491 fast/css3-text/css3-text-decoration
 webkit.org/b/76173 fast/css3-text/css3-text-align-last
 
-# CSS3 Background is not yet enabled (needs ENABLE_CSS3_BACKGROUND).
-webkit.org/b/37514 fast/backgrounds/background-position-parsing-2.html [ Text ]
-webkit.org/b/37514 fast/backgrounds/background-position-rendering.html [ Image ]
-
 # Our slow tests, in alphabetical order.
 webkit.org/b/57672 http/tests/local/fileapi/send-sliced-dragged-file.html [ Failure Pass ]
 

Modified: trunk/Source/_javascript_Core/ChangeLog (136414 => 136415)


--- trunk/Source/_javascript_Core/ChangeLog	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1,3 +1,14 @@
+2012-12-03  Alexis Menard  <ale...@webkit.org>
+
+        [Mac] Enable CSS3 background-position offset by default.
+        https://bugs.webkit.org/show_bug.cgi?id=103905
+
+        Reviewed by Simon Fraser.
+
+        Turn the flag on by default.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2012-12-02  Filip Pizlo  <fpi...@apple.com>
 
         DFG should trigger rage conversion from double to contiguous if it sees a GetByVal on Double being used in an integer context

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (136414 => 136415)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2012-12-03 18:46:06 UTC (rev 136415)
@@ -48,7 +48,7 @@
 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS;
 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION;
 ENABLE_CSS_VARIABLES = ;
-ENABLE_CSS3_BACKGROUND = ;
+ENABLE_CSS3_BACKGROUND = ENABLE_CSS3_BACKGROUND;
 ENABLE_CSS3_CONDITIONAL_RULES = ;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CUSTOM_SCHEME_HANDLER = ;

Modified: trunk/Source/WebCore/ChangeLog (136414 => 136415)


--- trunk/Source/WebCore/ChangeLog	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebCore/ChangeLog	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1,3 +1,19 @@
+2012-12-03  Alexis Menard  <ale...@webkit.org>
+
+        [Mac] Enable CSS3 background-position offset by default.
+        https://bugs.webkit.org/show_bug.cgi?id=103905
+
+        Reviewed by Simon Fraser.
+
+        Turn the flag on by default.
+
+        No new tests : covered by tests landed previously.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * css/CSSToStyleMap.cpp:
+        (WebCore::CSSToStyleMap::mapFillXPosition): Build fix in release on Mac with unused variable.
+        (WebCore::CSSToStyleMap::mapFillYPosition): Ditto.
+
 2012-12-03  Jan Keromnes  <j...@linux.com>
 
         Web Inspector: Implement context menus in CodeMirrorTextEditor

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (136414 => 136415)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2012-12-03 18:46:06 UTC (rev 136415)
@@ -48,7 +48,7 @@
 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS;
 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION;
 ENABLE_CSS_VARIABLES = ;
-ENABLE_CSS3_BACKGROUND = ;
+ENABLE_CSS3_BACKGROUND = ENABLE_CSS3_BACKGROUND;
 ENABLE_CSS3_CONDITIONAL_RULES = ;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CUSTOM_SCHEME_HANDLER = ;

Modified: trunk/Source/WebCore/css/CSSToStyleMap.cpp (136414 => 136415)


--- trunk/Source/WebCore/css/CSSToStyleMap.cpp	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebCore/css/CSSToStyleMap.cpp	2012-12-03 18:46:06 UTC (rev 136415)
@@ -229,7 +229,7 @@
 #if ENABLE(CSS3_BACKGROUND)
     Pair* pair = primitiveValue->getPairValue();
     if (pair) {
-        ASSERT(propertyID == CSSPropertyBackgroundPositionX);
+        ASSERT_UNUSED(propertyID, propertyID == CSSPropertyBackgroundPositionX);
         primitiveValue = pair->second();
     }
 #else
@@ -269,7 +269,7 @@
 #if ENABLE(CSS3_BACKGROUND)
     Pair* pair = primitiveValue->getPairValue();
     if (pair) {
-        ASSERT(propertyID == CSSPropertyBackgroundPositionY);
+        ASSERT_UNUSED(propertyID, propertyID == CSSPropertyBackgroundPositionY);
         primitiveValue = pair->second();
     }
 #else

Modified: trunk/Source/WebKit/mac/ChangeLog (136414 => 136415)


--- trunk/Source/WebKit/mac/ChangeLog	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1,3 +1,14 @@
+2012-12-03  Alexis Menard  <ale...@webkit.org>
+
+        [Mac] Enable CSS3 background-position offset by default.
+        https://bugs.webkit.org/show_bug.cgi?id=103905
+
+        Reviewed by Simon Fraser.
+
+        Turn the flag on by default.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2012-12-02  Yongjun Zhang  <yongjun_zh...@apple.com>
 
         Need a method to close all idle localstorage databases immediately.

Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (136414 => 136415)


--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2012-12-03 18:46:06 UTC (rev 136415)
@@ -48,7 +48,7 @@
 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS;
 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION;
 ENABLE_CSS_VARIABLES = ;
-ENABLE_CSS3_BACKGROUND = ;
+ENABLE_CSS3_BACKGROUND = ENABLE_CSS3_BACKGROUND;
 ENABLE_CSS3_CONDITIONAL_RULES = ;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CUSTOM_SCHEME_HANDLER = ;

Modified: trunk/Source/WebKit2/ChangeLog (136414 => 136415)


--- trunk/Source/WebKit2/ChangeLog	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebKit2/ChangeLog	2012-12-03 18:46:06 UTC (rev 136415)
@@ -1,3 +1,14 @@
+2012-12-03  Alexis Menard  <ale...@webkit.org>
+
+        [Mac] Enable CSS3 background-position offset by default.
+        https://bugs.webkit.org/show_bug.cgi?id=103905
+
+        Reviewed by Simon Fraser.
+
+        Turn the flag on by default.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2012-12-03  Ryuan Choi  <ryuan.c...@samsung.com>
 
         [EFL][WK2] Add contents,size,changed signal to the ewk_view API

Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (136414 => 136415)


--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2012-12-03 18:44:10 UTC (rev 136414)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2012-12-03 18:46:06 UTC (rev 136415)
@@ -48,7 +48,7 @@
 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS;
 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION;
 ENABLE_CSS_VARIABLES = ;
-ENABLE_CSS3_BACKGROUND = ;
+ENABLE_CSS3_BACKGROUND = ENABLE_CSS3_BACKGROUND;
 ENABLE_CSS3_CONDITIONAL_RULES = ;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CUSTOM_SCHEME_HANDLER = ;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to