Title: [136033] trunk/Source/WebKit/mac
- Revision
- 136033
- Author
- bda...@apple.com
- Date
- 2012-11-28 11:37:15 -0800 (Wed, 28 Nov 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=102970
[WK1] REGRESSION (r129545): Main frame doesn't rubberband unless
WebFrameLoadDelegate implements -webView:didFirstLayoutInFrame:
Reviewed by Sam Weinig.
We should always register for DidFirstLayout in WK1 since we do work
at that time besides just calling the delegate function.
* WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (136032 => 136033)
--- trunk/Source/WebKit/mac/ChangeLog 2012-11-28 19:30:51 UTC (rev 136032)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-11-28 19:37:15 UTC (rev 136033)
@@ -1,3 +1,16 @@
+2012-11-28 Beth Dakin <bda...@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=102970
+ [WK1] REGRESSION (r129545): Main frame doesn't rubberband unless
+ WebFrameLoadDelegate implements -webView:didFirstLayoutInFrame:
+
+ Reviewed by Sam Weinig.
+
+ We should always register for DidFirstLayout in WK1 since we do work
+ at that time besides just calling the delegate function.
+ * WebView/WebView.mm:
+ (-[WebView _cacheFrameLoadDelegateImplementations]):
+
2012-11-27 Michael Saboff <msab...@apple.com>
TextIterator unnecessarily converts 8 bit strings to 16 bits
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (136032 => 136033)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2012-11-28 19:30:51 UTC (rev 136032)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2012-11-28 19:37:15 UTC (rev 136033)
@@ -1686,9 +1686,7 @@
// for backwards compatibility.
Page* page = core(self);
if (page) {
- unsigned milestones = 0;
- if (cache->didFirstLayoutInFrameFunc)
- milestones |= DidFirstLayout;
+ unsigned milestones = DidFirstLayout;
if (cache->didFirstVisuallyNonEmptyLayoutInFrameFunc)
milestones |= DidFirstVisuallyNonEmptyLayout;
page->addLayoutMilestones(static_cast<LayoutMilestones>(milestones));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
